Gajim - 2025-09-20

> wurstsalat pushed 1 commits to branch gajim/master > > fix: Preferences: Fix updating proxy list - https://dev.gajim.org/gajim/gajim/-/commit/498373a7e95d5cc1d4dec63ccfdb52a848e054f7 > > Is this related to an error displayed when: 1. Go to Settings, select an account, Connection, Proxy, Gear wheel. 2. Close the window 3. Everything seems fine, but there's an "Error" message. ?? ``` Traceback (most recent call last): File "/app/lib/python3.12/site-packages/gajim/gtk/widgets.py", line 135, in __on_close_request self._cleanup() File "/app/lib/python3.12/site-packages/gajim/gtk/proxies.py", line 82, in _cleanup window_pref.update_proxy_list() File "/app/lib/python3.12/site-packages/gajim/gtk/preference/dialog.py", line 157, in update_proxy_list assert isinstance(group, MiscellaneousGroup) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError ``` ↺

Could a tooltip/hint help in the following situations? I remember reading that menu width is fixed, so I guess increasing its width is not an option. Translations could be shortened only by removing a word (such as "link" or "automatic"), but in the audio menu there is nothing to be done, as it's the name of a device. So I thought of a tooltip when hovering with mouse. What do you think?

https://disroot.org/upload/068cdf69-4ceb-76cc-815a-8ca1d92bb086/Gajim-Menu.png

Well, it's not true what I said about audio menu, but anyway, it's dificult to get it that shorter so that it fits.

yeah we need to find some solution for this

lovetox: how would you feel about using warnings.warn in some places in gajim and nbxmpp instead of log.warning? What's nice about it is that it avoids printing the same message over and over, which is desirable in some case. For instance, because of a misbehaving MUC service, my logs are filled with `(W) nbxmpp.m.muc (slidge.im) Invalid JID: None, 'NoneType' object has no attribute 'find'`, which is not very useful. Or maybe what could be improved here is to log something a bit more informative, like which room this happens in?

dont understand, why would i not want to have a log message for every warning?

sounds like much effort to determine from which log message in exactly which instance i dont want to have multiple lines, at the same time making sure i get them for different instances or contexts

what for? that your log has less lines?!

a log is for debugging, i dont want to think about what information is missing from a log

and for that specific message, yes of course you could pass context to that method so it can print the context also, but you can simply enable debug logging and see the context then also ..

seems like a generic except for something that should not happen at all

but if that specific error is important to you, feel free to add context

usually i pass the offending stanza, it should give enough context

wurstsalat pushed 1 commits to branch gajim/master cfix: Preferences: Don't allow to disable title bar on Windows - https://dev.gajim.org/gajim/gajim/-/commit/63f626e88a3e594a7520f4de202ce71e0b16e43d

lovetox, fair enough. there are valid cases for non-repeating warnings, sometimes it does not bring more info and just clutters the log, "burying" other important lines. But in this specific case I agree it's better to log everytime since it corresponds to different events. Logging more context with the warning is the way to go if I want to improve it. ✏

Gajim warnings about invalid and/or inconsistent incoming payloads are very useful and I'm grateful for them! :)

sometimes its easy if its in a stanza handler i usually print also the stanza, that should be enough context

but sometimes the validation is 3 methods deep, to gain context you would need to pass the context to all methods

we probably have no consistent methodology there, its all gut feeling, sometimes i probably thought its not worth the effort

Does Gajim do anything to change MAM Preferences by default? I'm trying to figure out where a problem is happening between a server and three different clients.

No

Check the server default maybe

Though I plan to check it on start and issue a warning if it is off

Yeah, unfortunately the server is one I don't operate or have logs for so I'm having to diagnose a black box here.

From asking around a bit, yes, it defaults to off. Thanks!