-
f(x)u
Hi, I’d like to contribute a patch to guard against None in generate_avatar_letter. Please grant me fork/branch rights. This causes an error which crashes gajim. My github is -> https://github.com/saksham-personal
-
okko
> Hi, I’d like to contribute a patch to guard against None in generate_avatar_letter. Please grant me fork/branch rights. This causes an error which crashes gajim. > My github is -> https://github.com/saksham-personal development happens on gitlab. https://dev.gajim.org/gajim/gajim ↺
-
betarays
> development happens on gitlab. https://dev.gajim.org/gajim/gajim (there’s a “sign in with github” button there) ↺
-
lovetox
Yes but also there it needs to be granted
-
lovetox
I check later
-
f(x)u
> > Hi, I’d like to contribute a patch to guard against None in generate_avatar_letter. Please grant me fork/branch rights. This causes an error which crashes gajim. > > My github is -> https://github.com/saksham-personal > development happens on gitlab. https://dev.gajim.org/gajim/gajim https://dev.gajim.org/saksham-personal
-
lovetox
f(x)u: done
-
f(x)u
https://dev.gajim.org/gajim/gajim/-/merge_requests/1159 lovetox pls review
-
cal0pteryx
f(x)u: is there a more complete traceback? Everytime I saw this traceback, there were other issues happening before (e.g. a group chat added to the roster, rendering Gajim broken)
-
d-04
https://upload.xmpp.earth:5281/file_share/0687f98e-476c-7a6c-a542-890f18a3eee9/Screenshot%20From%202025-07-22%2015-53-34.png
-
d-04
Hey, I used gajim on NixOS natively with v2.2.0. I saw that 2.3.3 came with a ui overhaul and wanted to try that through Flatpak. Im getting an issue that some icons are missing, does anyne know why that is? A friend of mine also reported having this issue on MacOS. Thanks :)
-
lovetox
Really you get this on flatpak install?
-
d-04
Yep ^^" Im not quite familiar with flatpaks but It seems it can access the usual icons im guessing: ``` λ flatpak run --command=sh org.gajim.Gajim [📦 org.gajim.Gajim ~]$ ls /usr/share/icons/ Adwaita hicolor ```✎ -
d-04
Yep ^^" Im not very familiar with flatpaks but It seems it can access the usual icons: ``` λ flatpak run --command=sh org.gajim.Gajim [📦 org.gajim.Gajim ~]$ ls /usr/share/icons/ Adwaita hicolor ``` ✏
-
alexia
> Hey, I used gajim on NixOS natively with v2.2.0. I saw that 2.3.3 came with a ui overhaul and wanted to try that through Flatpak. Im getting an issue that some icons are missing, does anyne know why that is? A friend of mine also reported having this issue on MacOS. > Thanks :) oh these *should* be in libadwaita but clearly something is going wrong...
-
d-04
huuuh interesting, So once I change my gtk theme to Adwaita this works, but then my entire desktop is Adwaita... So im guessing this means Gajim uses some Icon types that Papirus-Dark doesnt include? ``` 98 ⋮ 98 │ iconTheme = { 99 ⋮ │ name = "Papirus-Dark"; 100⋮ │ package = pkgs.papirus-icon-theme; ⋮ 99 │ name = "Adwaita"; ⋮ 100│ package = pkgs.adwaita-icon-theme; 101⋮ 101│ }; ```✎ -
d-04
huuuh interesting, So once I change my gtk theme to Adwaita this works, but then my entire desktop is Adwaita... So im guessing this means Gajim uses some Icon types that Papirus-Dark doesnt include? ``` iconTheme = { - name = "Papirus-Dark"; - package = pkgs.papirus-icon-theme; + name = "Adwaita"; + package = pkgs.adwaita-icon-theme; }; ``` ✏
-
alexia
thing is, LibAdwaita shouldn't use the system icon theme by default and yes, Adwaita uses a nonstandard set of icons because again, it is intended that it ships it's own icons
-
d-04
It is indeed interesting, because I also thought that was the intent of shipping everything in a flatpak. But anyways after some trying out I can keep my papirus theme and add the Adwaita theme globally: ```diff + environment.systemPackages = with pkgs; [ + adwaita-icon-theme # extra fallback theme + ]; ``` No idea why it seems to use my Host icon packs but everything works well now so thanks for guiding me in the right direction :)
❤️ 1 -
f(x)u
> f(x)u: is there a more complete traceback? Everytime I saw this traceback, there were other issues happening before (e.g. a group chat added to the https://conference.gajim.org:5281/pastebin/4110e5f2-f756-43f9-bded-f99d5c0b0c08
-
f(x)u
This happened whenever an user has no Name (idk how thats possible), but this caused a popup error again and again. Ideally, no existing user should have the attribute 'name' to be None.
-
lovetox
f(x)u: if you can reproduce it there should be a longer traceback or?
-
lovetox
Ah you posted it already
-
f(x)u
Hi, actually the pipeline failed due to some static checkers on my earlier merge request, I have made a new merge request at https://dev.gajim.org/gajim/gajim/-/merge_requests/1160 Please verify and decline the earlier merge request which resulted in pipeline fail probably due to static checks.
-
lovetox
f(x)u, from where did you install this Gajim version?
-
lovetox
the code in your traceback does not match with the Gajim Version
-
lovetox
get_muc_surface() does not exist in Gajims codebase since a year
-
f(x)u
huh
-
f(x)u
> f(x)u, from where did you install this Gajim version? flatpak
-
lovetox
further the Gajim version 2.3.2 it prints, and nbxmpp 4.5.4 cannot be correct, as Gajim 2.3 needs nbxmpp > 6.2
-
lovetox
i highly doubt thats flatpak ..
-
lovetox
looks like a Gajim Gtk3 version, it even says in the version Gtk 3
-
lovetox
either way, all the code in the traceback is now different, i checked all calls to generate_avatar_letter() and i dont see how None can be ever passed to this method
-
lovetox
btw, you dont need to create a new MR everytime you change something on your branch
-
lovetox
a MR is the difference between the original repo and yours
-
lovetox
you can just push changes to your fork, and they will automatically show up in the MR
-
lissine
(you can use git commit --amend and git push --force)
-
f(x)u
Thank you, it is my first time contributing to the project.
-
lovetox
yeah so, first find out why your installation runs 2024 code, maybe check if its really a flatpak install and if try to reinstall
-
lovetox
if you can produce the error on the newest Gajim version, reopen the merge requests
-
f(x)u
okayy : )
-
hau
fix emoji
-
hau
send help
-
alexia
> fix emoji can you be any more specific as to what your issue is? ↺
-
wunderbar
The icon in the systray no longer flashes for personal messages. Is this a bug? I am using the Windows 2.3.3 version.
-
hannibal
wunderbar: https://dev.gajim.org/gajim/gajim/-/issues/12341
-
keef
What does it mean if i have a yellow warning sign next to my message saying "service-unavailable"?