Gajim - 2024-11-10

  1. meson

    lovetox, I've pushed additional changes. Would you like to check if those are fine with you? My local testing successfully migrated ~6k FT messages.

  2. lovetox

    meson, can you format your changes with black

  3. lovetox

    otherwise more shows up then it should

  4. lovetox

    or simply install pre-commit

  5. lovetox

    why are you trying to analyse the file when downloading?

  6. lovetox

    why do we need the result?

  7. meson

    I'm a bit puzzled: I've installed now both `pre-commit` and `black` with pip in my venv. If I call `black gajim` it says `No Python files are present to be formatted. Nothing to do 😴`

  8. lovetox

    from inside the repository "black ."

  9. meson

    If I run it in the gaji root directory it says all done, 11 files unchanged, but I'd expect some changes to appear in PyCharm's commit box, but don't see any.

  10. lovetox

    preview_audio should use double quotes

  11. lovetox

    maybe you changed that but did not push yet

  12. meson

    So, when do we use double and when single quotes?

  13. lovetox

    we are switching to double, for everything in gtk module its double now

  14. lovetox

    and black does that automatically

  15. meson

    good to know, bc I've remembered _we use single quotes_ and started to "fix" that 🤦

  16. meson

    I should wondered though in the first place ✎

  17. meson

    I should have wondered though in the first place ✏

  18. meson

    Anyway I'm afk now, so no rush for a quick.review