Gajim - 2024-11-05

diane: looks like your theme is broken. The light/dark switch in Gajim or of the system (if system was selected in Gajim), should change the colors immediately

Thanks hannibal I'll have to dig around more.

if you disable an account and then re-enable it, you lose pinned room and also workspaces setting (like which rooms are in which workspace)

1.9.5 Windows

Yes not a bug

roughnecks: there is a merge request waiting to fix that ;)

Would be nice to store workspaces and pinning in a private PEP node, so that Gajim at home and at work have that synchronized.

> Would be nice to store workspaces and pinning in a private PEP node, so that Gajim at home and at work have that synchronized. 👍 ↺

Sounds easy, is sadly not trivial

is this also to be expected?

https://xmpp.woodpeckersnest.space/file_share/yJIV5TUHTZq1ImnbdKyuaKwt/ecf20f0d-0405-4bfe-a176-4717e577b243.png

window heigth

when I try to run `python gajim/gtk/builder.py` I get `ImportError: cannot import name 'TYPE_CHECKING' from partially initialized module 'typing' (most likely due to a circular import) (/usr/lib64/python3.13/typing.py)`

What are you trying to achieve by running builder.py?

I've confused in the rush

Which python version does the windows build use?

meson: the latest from msys

Should be 3.11.10

> Would be nice to store workspaces and pinning in a private PEP node, so that Gajim at home and at work have that synchronized. 👍 ↺

Does Gajim support MIX group chat?

No

Meson please make the python change against master

lovetox pushed 1 commits to branch gajim/master refactor: Remove obsolete code - https://dev.gajim.org/gajim/gajim/-/commit/fab432add7f0efacb32f998a9aec360ecea33911

> There is a menu above it that shows you sort option Could you provide more details? I can't find any sort option for chats nor the possibility to pin some contacts to top. I only see all of them in alphabetic order

are you maybe on an old version?

the current version has a pin option

1.3.3

nomehacenada, this comment talked about the roster, not chats

> nomehacenada, this comment talked about the roster, not chats Ah

I'm seeing that there's 1.9.5 How come i got 1.3.3 installed on mint recently

cal0pteryx: create_thumbnail always saves previews in the png format, but the thumbnails are stored with their original suffix. Any reasons not to change the suffic to always .png? ✏

I did that and forgot to change the suffix maybe ✏

If this were now corrected, the cache folder would needed to be cleared once?

> I'm seeing that there's 1.9.5 > How come i got 1.3.3 installed on mint recently Ah, ubuntu 22.04, I see :(

Talking about these two code locations https://dev.gajim.org/gajim/gajim/-/blob/gtk4/gajim/common/util/image.py?ref_type=heads#L130 https://dev.gajim.org/gajim/gajim/-/blob/gtk4/gajim/common/util/preview.py?ref_type=heads#L70

thanks should be fixed ✏

nomehacenada, you can download the most current version via flathub

Yes, true. I may try that if it lets me pin chats and sort by last message

hannibal, switch to something different then the system theme, does also not work for me anymore on the newest ubuntu

my theme is Yaru-dark it seems this theme does not support any light color

if i set it to Yaru, then there is a switch in GTK inspector "Dark Variant" if i switch that it correctly switches between light and dark

the same button does nothing for Yaru-dark

crazy, i cannot even look at the light theme after using years dark

it hurts my eyes

> Gajim is currently migrating from GTK3 to GTK4. 🔧 GTK is Gajim's user interface toolkit. It provides building blocks, like windows, buttons and labels. 🧩 Read more here: https://fosstodon.org/@gajim/113426619160581769 in the current gtk4 branch: do I need to enable something to make nickname completion work? ↺

there's no popup for me if I hit tab

type @

nice :)

there's a white space missing after the " , " :p

hannibal, diane, i found out the problem, you need to set a system theme that does not have a -dark prefix

as these system themes simply do not support light style

so changing the option in gajim does nothing

> there's a white space missing after the " , " :p fixed ↺

lovetox, I found if I set Dark Theme to system, and theme to default the topic box in a group chat would change color. But nothing else changes for me. There's quite possibly something missing I'd expect the widget backgrounds would change.

its because your system os theme is set to something with prefix -dark

are you on gnome?

Debian testing with gnome 46.4

I also just read the developing instructions and cloned the repository, I wonder if it's something like files are missing from the debian package

download Tweaks, then you can see what theme is set

lovetox, we had the problem with the dark theme already in ubuntu 22.04 https://dev.gajim.org/gajim/gajim/-/issues/10996#note_206262

lovetox pushed 2 commits to branch gajim/master cq: Add black config - https://dev.gajim.org/gajim/gajim/-/commit/00d8cab18ce9bd90857e3bd13134f341d795eb8c cq: Format support scripts with black - https://dev.gajim.org/gajim/gajim/-/commit/c3a20e554012891f9fa44540cb145b1fc5901ba4

I'm a little bit confused: > # Gio does also guess based on file content https://dev.gajim.org/gajim/gajim/-/blob/gtk4/gajim/common/util/preview.py?ref_type=heads#L204 `guess_mime_type(preview.orig_path, data)` https://dev.gajim.org/gajim/gajim/-/blob/gtk4/gajim/common/preview.py?ref_type=heads#L393 If I understand it correctly data is of the thumbnail == png? if so, how would it help here to guess the correct mime type of the orig file? ✏

why would we want to know the mime-type of a thumbnail?

we dont need to guess, if we store all thumbnails in png

not sure why you think data is of the thumbnail

the method is called _on_orig_load_finished()

we load the bytes of the original file, meaning not the thumbnail

ah i think you mislinked and you mean the method underneath

hmm yeah thats a problem if we load just the thumb .. i need to look into if we then need the mime-type

hm it doesnt matter anywhere

we can basically set it to None when we just load the thumbnail

perfect, confusion resolved

because we dont really know what the mime-type will be, and im not inclined to load the original

I ask bc I've written a frame extractor to generate previews of videos as a start before implementing the gtk4 media player:

https://share.conversations.im/meeson_/Z7uj3tyXKHHDjAAf/Screenshot_20241105_230740.png

Works, but the code will need a review definitely

Good thing, it's not much

i can get down with a frame extraktor for a preview picture, but having a media player in Gajim seems overdoing it

lovetox, it's bascially ``` media_stream = Gtk.MediaFile.new_for_filename("video.mp4") video = Gtk.Video.new_for_media_stream(media_stream) ```` ✏

lovetox, it's bascially ``` media_stream = Gtk.MediaFile.new_for_filename("video.mp4") video = Gtk.Video.new_for_media_stream(media_stream) ``` ✏

yes, for probably like a handful of formats

and then people send videos with god know what encoding from their phones

and we have 17 issues "I send a video but it does not play in Gajim"

This GTK thing is just a proof of concept or not? its not trying to be a mediaplayer

and it probably needs a shit tone of dependencies

depending on what codecs you want to support

🙃 Link told me yesterday that in the #gtk they were > talking about what the widget should be and what it currently is and how nobody is using it currently.

what does that sentence tell me?

:D

lovetox, err, you will never support all formats people might use.

Current phones like to use codecs you have to pay multiple companies and can’t really know which ones before you get sued.

So no one really bothers with that.

It’s usually fine to use whatever is supported by Gstreamer, and to let users open them in a different application if you can’t play it.

not convincing

if i offer a media player, users will think its a goal of Gajim to play videos

and will report everything that does not work

sorry, its one click, and it opens in your favourite media player

If you make it clear why it isn’t working, just like web browsers do, it should be fine.

why do i need to look at it in a 100x100 frame?

What do you mean?

i dont implement stuff "because i can"

there needs to be a clear benefit

i dont see it, its the same amount of clicks the user has to do

we let them use a dedicated application, he will be more happy with that in any case

You prefer to display a link and users can click on it to play the video? I think current chat software all try to make it look integrated into it.

no we show a image preview

and he can click the play button

but it opens in another app

So you still have to have all of the machinery to generate an image from a video, it isn’t much more to also display the video itself then.

I know I personally prefer to use mpv for all of my videos, but most people I know don’t do that.

?! what do they do?

even phone clients like conversations dont have a integrated video player

Try literally any other phone client, such as WhatsApp, Signal, Telegram…

not a single user i remember ever asked for a integrated video player

you proposing this only because GTK provides a widget, not because it fills a need for someone

can it playback GIF? because thats something people really want to play in the app

I don’t think I proposed anything, but I also don’t know what people actually want, I’ve never done any user study on Gajim.

I think GIF is done using GtkPicture instead, but also no one uses GIF any more, it’s always encoded as video nowadays.

there is a gif plugin in gstreamer rs plugins :D

GIF means a short video without sound, nowadays.

Right, if your distribution packages those plugins that should also work.

mine doesn't that's why I gave up on porting gajim's video preview for now. there is no gtk4 gstreamer widget I think apart from that in gstreamers rs plugins

cal0pteryx, the GtkVideo widget is kind of that.

true most gifs are now videos, giphy seems to use webp

but it doesn't allow for pipelines afaiu. I mean the video preview of your webcam in preferences, I didn't specify that

but generally regarding video preview for gajim's file preview: I'm all for integrating GTK's default video widget. if it's not a supported format, just put a label there and a button "No direct playback available. Click to open", done. it doesn't hurt and it's nice to have it integrated

lovetox, webm*

most importantly, there is no media break, if you like to call it that. all actions stay within the app

Link Mauve, hmm at least the fileextension is webp if you copy the link

WebP can also do animations, but just like APNG it encodes every frame standalone, instead of taking advantage of the previous frame like real video formats.

Most websites will encode “GIFs” to proper video formats to drastically reduce their weight.

I've seen websites autoplaying/loading several mp4 files of 100 mb ✏

. ✏

Is there an easy way to add an a transparent play-button overlay onto an image button?

Of the default file preview widget

yes GtkOverlay

Right, then I will go with the simple frame preview solution first for now only :) The video player - if it should come - can wait ;)

meson, cal0pteryx , i rebased the branch and force pushed