-
Mike Yellow
> lovetox pushed 1 commits to branch gajim/master > > fix: Fix wrapping lines for long words - https://dev.gajim.org/gajim/gajim/-/commit/f0c4c901be24373a1824a9b25598b309c33073c0 > > Does it mean that it fixed not wrapping lines for the languages which use no spaces (Chinese, Korean, Japanese)? ↺
-
lovetox
Are you saying in Chinese there is no way to know when a word ends?
-
Mike Yellow
Ye...s, Chinese use no spaces “ ”.
-
lovetox
But there must still be a way to know when a word ends or? How do you split a word correctly? Or does it not matter and you can split at any symbol?
-
lovetox
But yes this commit should revert to old behavior
❤ 1 -
Mike Yellow
In Chinese, the concept of “word” is different with western languages, Chinese just wrap a sentence whatever it split a word or not, also uses no “-” at the end of a line.
-
Mike Yellow
> But yes this commit should revert to old behavior That would be good, no problem anymore. ↺
-
Mike Yellow
Thank you.
-
fjklp
> But yes this commit should revert to old behavior Oh hell yeah. I'm happy to see this. I looked at the commit before and saw that there is a condition ``` if os.environ['GAJIM_FORCE_WORD_WRAP']: self.set_line_wrap_mode(Pango.WrapMode.WORD) ``` Is there any environment where this applies currently? ↺
-
lovetox
Any where people want to dos you with messages that let Gajims segfault
-
fjklp
shouldn't that close https://dev.gajim.org/gajim/gajim/-/issues/11854 ?
-
cal0pteryx
fjklp: its not really fixed.
-
cal0pteryx
It's just a flag which lets people revert back to the safe behavior if there are issues
-
fjklp
I see
-
fjklp
I tested it and it wrapped a long word for me
-
cal0pteryx
fjklp: essentiall, we disabled wrapping, and now we enabled it again