Gajim - 2024-04-20

hannibal, thanks for the info, but this alone is not enough, GLib needs also to support FileIcon for the notification portal backend

and then its not even clear this is the best solution

currently we need to save avatar icons in a small format to a cache folder just so we can pass a file path, this means more writes to disk, more reads

we do this only now for the freedesktop backend, because GLib simply does not support pixbuf or bytesicon

as i understand it they will never support pixbuf, and bytesicon would need to be implemented

hm seems its not necessary for the portal backend to add support because they serialize the whole notification

so ignore that

lovetox pushed 1 commits to branch gajim/master ci: Allow debian deploy to fail - https://dev.gajim.org/gajim/gajim/-/commit/3adad910cca245e10f7c2da1a9178a5aee45f6ba

> this means more writes to disk, more reads lovetox: Maybe something like this could be considered? https://unix.stackexchange.com/questions/66990/create-a-virtual-file-that-is-actually-a-command

> i think we didnt have notifications with avatars on flatpak, but with this MR this should now work lovetox, avatars on flatpak work with current master. Do you still want me to test the MR with flatpak?

User Avatar in a notification?

yes

.. this should not work

are you using gnome?

yes

ok this shit is 20 layers deep

we call Gio.Notification, which determines a backend, in flatpak case the portal backend, which passes the notification object further witout manipulating it

then it depends what portal backend the xdg-desktop-portal uses

in the case of gnome desktop env it uses probably xdg-desktop-portal-gtk

There is also xdg-desktop-portal-gnome

xdg-desktop-portal-gtk now checks if dbus name org.gtk.Notifications is available

and if so, it just passes the notification object unseen to the dbus interface, which support pixbufs

if the name is not available, it uses the fdo notification dbus name

org.freedesktop.Notifications

but this one does not support serialized notification objects, so xdg-desktop-portal-gtk needs to convert the notification object to whatever API this dbus interface wnats

and there, it does not support conversion of all icons, and especially not pixbuf

so yes hannibal please test the branch

because it works only by accident for you because you use gnome

and xdg-desktop-portal-gnome seems to have no notification code at all

so dont know how that actually works if someone has installed that

then of course there are even more backends, for example KDE does also only support a icon-name and bytes icon

## Versions: https://conference.gajim.org:5281/pastebin/e37db1d0-662a-438e-88a2-c1b1f75c929e

Mike Yellow, restart Gajim. it might be that there was a third party app blocking database access, or gajim wasn't shutdown properly

Thank you.

Mike Yellow: yo

can't message you

1

lovetox pushed 1 commits to branch gajim/master cfix: OMEMO: Handle unknown fingerprint correctly - https://dev.gajim.org/gajim/gajim/-/commit/f3971067b7d11dbbe6a8e6c756a4635b2cd963f9

lovetox pushed 2 commits to branch gajim/master imprv: Notifications: Make avatars available on more platforms - https://dev.gajim.org/gajim/gajim/-/commit/0215516bd40bbba6c6f8702ec3a801404efb7814 refactor: Notifications: Improve Linux backend - https://dev.gajim.org/gajim/gajim/-/commit/a46997d8e971b3ae06c7a1d4bbfa8de4006677f9