Gajim - 2024-03-30

What's a quick way to get a list of a contact's resources

Check the contact module

so like how broken is jingle ft

im having trouble finding any code that would notify the user of incoming transfer

No idea didn't look at it for years

But maybe look into the filezransferdialog

My gajim client shows the date in the chat window in a strange format "Sat 03/30/24" No one should use a 2 digit year anymore. How can I set RFC / ISO date in the chat client? I even would suggest it should be the default.

jstein: advanced config gives you complete freedom: search for "_format"

cal0pteryx, thank you. That works fine. Only z in %Y-%M-%d %H:%m:%S UTC %z is not interpreted

I expected +02:00

Hm maybe that specific object is not tz-aware. The next release will have fixes for that

jstein: it depends on your system settingd

And UTC is not a valid time formatting

It's also not clear why you would want a timezone

I hope you know in what timezone you live

I live in a country, that still hat daylight saving we shift the clocks in stupid way (tomorrow for example) Without timszone you have 02:00 A and 02:00 B

And?

I want to see the real time

Because of that one day you show the whole year everywhere your timezone?

yes sure

it does not cost a cent

why do I have a clock, if it is running mad 2 h per year? ;-)

Hm but I agree it should work

I will check, if I need "UTC" as a string

with " signs

Why do you need utc

I just like that

I can't argue with that 😁

Look into python time formatting

when you travel around the world and your flight tickets are all in local time and try to plan your stop over you learn why it is stupid to drop the timezone

It would well be that random characters are not supported

Only separatora

removed UTC. I think %z is ignored in my 1.8.4

Will try with next release again

thanks so far

But check your system settings

Hi 👋

jstein, i tested this, and it seems like a bug in gajim

probably as cal0pteryx said, the object is not timezone aware, so it cant print the timezone because it has none

do I understand correctly that gajim gui is un-unit-testable mostly

like the chat view specificalyl

I tried instantiating it with a bunch of MagicMocks all over the place to no avail

also how dead is filetransfer.py? I see it instantiates gtk widgets by hand instead of using a .ui, I guess it must be ancient

thats mostly a preference thing, there is nothing better to define a gui in a xml file

>do I understand correctly that gajim gui is un-unit-testable mostly honestly I am wasting a lot of time repeating the same action by hand trying to get it to work, specifically gui and event stuff. I am spending more time on doing gui than I did on the actual logic!

we tend to do it, to reduce the code, and its sometimes easier to use a gui editor

> I am spending more time on doing gui than I did on the actual logic! thats quite normal

all the super logic does not bring you anything if you dont have a good GUI for it

also yes GUI in general (if we are not talking about web applications) are basically not unit testable

or its very much effort at least

its also very much effort on the web i guess, but as its such a big market, there were solutions developed for it

and its all using one thing, html, while with native guis there are a lot of different frameworks and no generic way to test it

I mocked around CallWindow and only now realize how much time that saved. Honestly infuriating spending more time on drawing a simple goddamn button than on what that button does

>no generic way to test it Doesn't have to be generic? The gui just has to be loosely coupled I think. Gtk lets you simulate clicks and stuff

Also I'm not sure how this should really be, but gajim's gui seems to be rather "fat" and I'm wondering what the rationale is: like, why handle CallUpdated and work out what that actually meant inside the Window object instead of exposing methods like "tell user we're connect{ing,ed}", "display video with this widget"? Especially given that guis indeed are more likely to be hard to unit test, wouldn't you want to keep the logic there to a minimum and move it to other places?

we usually do that, non-gui logic is in common

gui logic is in gtk folder

the general idea or goal would be that you could start a gajim session without a GUI, headless so to to speak

i dont understand your remark about CallUpdated, its a event raised by the common module, a gui code can receive it if it subscribes to this event

thats a usual pattern, i dont understand what you are proposing to replace this with

or are you saying CallUpdated could be more specific, like CallConnected, CallDisconnected, etc

but we have code in the test folder that instantiates some windows or widgets, this can help immensely if you test some code.

but thats not what i call a unit test. A unit test could run on a server in some CI job, without human interaction.

hooking up a button to the right method is usually not the thing that causes bugs, even if , its noticed fast by users, reported, can be easily described, and is generally something that is fixed very fast

why a call suddenly is interrupted, because some low level logic in the jingle or network code does not work, is not at all easy to debug, can not be good described, often needs extensive debug logs and much time to find the issue, if at all possible.

so thats, while it would of course be nice to end 2 end test code with the GUI, i think its not the big game changer