Gajim - 2023-07-25

Could you please explain why TreeView was preferred over ListBox for the roster?

It's faster with many entries and you can group entries under names, like members, admins, etc

Got it.

I was looking for a way to remove a contact

I see that the roster menu is only _evokable_ with a mouse right click on a contact item in the treeview

Since I need a way to evoke the roster menu without the mouse, I looked for ways so that the menu can be evoked with Gdk.KEY_Menu

But I see that getting the content of treeview item currently under focus is done with checking the position of the cursor (event.x and event.y) ✏

So It seems to me that getting the current roster item from `roster_treeview` is not doable without querying cursor position

And I think it implies that evoking the roster menu for a specific contact item is not doable solely using keyboard events

Please correct me if I'm wrong

It is. Select with keyboard a contact and on keypress open the menu

kurion: focus the roster, navigate using arrow keys, press right click button on keyboard, move to correct item by arrow key, enter ?

I tried

But if the cursor is elsewhere (even if roster item is highlighted when navigating with keyboard)

Menu can not only be opened with cursor position

a right click does not invoke the roster menu for that item

Read the docs for GTK menu or gio.menu

I see in `_on_roster_button_press_event` that the logical process of determining the jid of the currently selected roster item uses `treeview.get_path_at_pos` first.

Which of course works with cursor position

What I am looking for is something like `treeview.get_selected_child()`

But there is no such method available for treeviews

How can I bypass `get_path_at_pos` and still somehow determine the jid of currently selected/highlighted roster item so that I can call `_show_contact_menu` with the jid?

You can get the selected node, look better in the docs

I looked for it.

Should I use `get_selected()` from Gtk.TreeSelection class?

Yes

That's not good

Yup

kurion: will you open some PR later? :)

Still not sure.

Actually, some of my code contains bad practises like using underscored methods outside of the parent class

I'm sure those things can be improved during the review process ✏

someone is sending spam messages on disroot.org mucs that crash Gajim. Probably too long or so. the messages are random garbage as far as I can tell

other clients seem uneffected

I guess Gajim is difficult to solve it. But it does not matter, I think it is a good thing to urge inexperienced room owners to learn how to prevent from being spammed.

meson: That's really nice to know. I'll have to learn how to make PRs :P ✏

Kris: should not be the case with newer gajim versions

I am on 1.7.3

ah I guess the fedora repos are not up to date 😓️

I'll switch to the flatpack 🤷‍♂️️

Given how active the development of gajim has been for the past months, thanks to the amazing work by its devs, I’ve happily switched to flatpak for a while. The only annoying issue I have is drag’n’dropping attachments to the chat window does not work for me, but ctrl+C ctrl+V is usually good enough for images.

nicoco: you need a recent version of gtk on your host system for drag and drop to work with flatpak

kurion: one way is to fork Gajim on Gitlab, create a branch for your feature, commit and push your changes to your fork on Gitlab. On Gitlab you'll then find a dialog to create a PR for your changes of your feature branch.

Hi, someone with write access may want to add add https://packages.gentoo.org/packages/net-im/gajim in Packages section on https://dev.gajim.org/gajim/gajim/-/blob/master/README.md

jstein: dp you know about repology.org ?

After long search sessions and trial-and-error, finally came up with the following: ``` def _on_roster_key_press_event(self, treeview: Gtk.TreeView, event: Gdk.EventKey) -> None: if event.keyval == Gdk.KEY_Menu: selection = treeview.get_selection() (model, iter_)= selection.get_selected() assert iter_ is not None jid = model.get_value(iter_, 3) self._show_contact_menu(jid, treeview, None) ```

TreeViews are complicated indeed

` jid = model.get_value(iter_, 3)` - I admit this line is not great to read.

`contact_store` is defined inside `roster.ui`. So it is not apparently clear to a reader what 3 actually refers to.

will have to add a conditional to check for Groupchat though

IMHO, this short code block looks nicer than the process of determining the jid in `_on_roster_button_press_event`

But I agree that you need to get cursor position to determine exactly where to popup the contact menu

The above method, funny enough, pops up the contact menu pointing to the the middle of the pane/grid divider. ✏

Now I will have to do somewhat of a gymnastics exercise to ensure a fluid UX

cal0pteryx, yes. Great project. Perhaps even better to drop all distributions from that list and simply add one repology link or badge https://repology.org/project/gajim/versions

kurion, why would a blind person care where a popup is located?

The blind person will not care, tbh\

But if I want to make a PR, I guess I should care

lovetox, some people might be blind, but they can still see a tiny bit.

For instance changes in luminosity (imagine an extremely blurry screen for instance), or generic shapes (like a rectangle in some corner).

Some can even read if they put their eye extremely close to the screen, with extremely zoomed in everything.

It always depends from person to person, but some handicaps aren’t on or off.

I need help, whenever I type some words and press space, my entire message gets changed to something else

It also depends on their current state of fatigue, stuff like that.

altblex: do you have acronym expander plugin turned on?

Link Mauve: yes, you could say there's a continuous spectrum of degree of blindness.

Yes, removing that fixed it

Thanks

finally have a working `_on_roster_key_press_event` method. I am hoping that the little bit of hardcoding I used here is harmless

``` https://conference.gajim.org:5281/pastebin/1d88e322-1c49-47e6-bfab-a00179774580

Still missing the check for Groupchat. But I'm not sure how to do it.

didn't want to touch any other method to accept a Gdk.EventKey along with the Gdk.EventButton

So ended up creating an EventButton

Very non-standard, I admit

If this little UX thing is worth the time and effort of a PR review process, I will make a PR. What do you say?

I have made several other modifications (mostly EventKey handling) during the last month. I will try push most of them eventually.

im working since 20 years with computers

TIL there is a menu button

its not on my keyboard though

i think its useful feature, but we have many context menus ..

hard to keep all working with a menu button if only very few people use this

i think if you make just for that a PR we could work to get it in, to have at least an example how to make a menu key for context menus work

about the code

look at _on_roster_button_press_event(), use the Column Enum to access columns in a more readable way

Column.IS_CONTACT tells you if its a group or contact

you need to convert the path with path = self._modelfilter.convert_path_to_child_path(path)

otherwise your code will show a wrong menu, when a filter is applied to the roster

further if we do this more often the GajimPopover should be refactored to take a rectangle instead of a EventButton

then we can save the dummy EventButton creation