Gajim - 2019-03-16


  1. RonUL_ lovetox, Hi, i.e. 4cjw6cwpeaeppfqz.onion
  2. lovetox seems to be a problem with onion adresses
  3. lovetox works fine here with normal domains
  4. lovetox i investigate
  5. bot Philipp Hörist modified an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9622 >: #9622: < не знаю что могло пойти не так >
  6. bot Philipp Hörist modified an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9622 >: #9622: < Error when quitting Gajim >
  7. maltel The data structure additional_data seems to be one of the ways to pass data around [https://dev.gajim.org/gajim/gajim/merge_requests/72] between plugins and gajim. Is there something I should keep in mind when extending this?
  8. maltel Concretely: additional_data['encrypted'] seems to store the 'name' of the standard/tool/plugin and 'fingerprint' of the key for which a message was encrypted. I was thinking of also passing the fingerprint of the key a message was signed with as well as the trust level for that key from the OMEMO plugin, and then using this when displaying the lock symbol and its tooltip in gajim.
  9. maltel Does this sound reasonable? Should this extra information go into additional_data['encrypted'] as well or perhaps into additional_data['authenticated']?
  10. lovetox do we not already pass the fingerprint
  11. maltel the OMEMO plugin actually doesn't pass any fingerprint I believe (omemo/module/omemo.py, line 188 is I think the only place in the plugin where additional_data is touched).
  12. lovetox on what branch are you looking?
  13. maltel master, in which one should I look?
  14. lovetox then look at omemo.py around line 243
  15. lovetox you look for outgoing messages
  16. lovetox but this makes not that much sense
  17. lovetox because you can only encrypt to trusted peers
  18. lovetox and for saving the trust to the database there are 2 philosophys how you can approach this
  19. lovetox either save the trust that this key had at that point in time, then we have to save it to the db
  20. lovetox or you always want to show the trust of the key the message was written with at time you look at the message
  21. lovetox then gajim would have to query the db with the fingerprint for the current trust everytime the message is loaded
  22. lovetox but saving the current trust is probably easier
  23. maltel oh, I see, my mistake @ where the fingerprint is passed, thanks. And I didn't think of the two options you mentioned... Both seem to have upsides and downsides, but I think either would be an improvement.
  24. maltel So for saving the current trust, could the next steps roughly be that I have a look at around line 243 as you point out and try to figure out if that information can be added to properties.encrypted as well and try to understand how to use that from where the lock is drawn?
  25. lovetox yes you can add whatever you want to the dict
  26. lovetox it will be written to the database in json
  27. lovetox then you look up in gajim where the fingerprint is drawn, probably in conversations_textview
  28. lovetox and do whatever you want with the information
  29. maltel yes, I already found that (@conversations_textview), it uses additonal_data['encrypted'] already, which is why I looked for that at first. Thanks for your help - I will see what I can do later
  30. lovetox dont develop with your real account on master omemo plugin
  31. lovetox not sure how stable it is
  32. lovetox otherwise you might unessarily generate new keys etc which leads to many new fingerprints for your contacts
  33. maltel Right, thanks for the warning. I will use an extra testing account for this. :)
  34. lovetox if you wonder how you can start multiple gajim instances
  35. lovetox use the -p switch on command line
  36. lovetox -p dev
  37. lovetox for example to add a dev profile to gajim
  38. bot Philipp Hörist closed an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9573 >: #9573: < Connecting to an onion service leaks DNS requests to clearnet >
  39. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *979c7d25* < https://dev.gajim.org/gajim/gajim/commit/979c7d255316ea69bf688bf6940f91a1a407adf5 > Dont leak DNS query if we connect via proxy Fixes #9573
  40. bot Daniel Brötzmann modified an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9622 >: #9622: < Error when quitting Gajim >
  41. bot Philipp Hörist closed an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9622 >: #9622: < Error when quitting Gajim >
  42. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *fa464d43* < https://dev.gajim.org/gajim/gajim/commit/fa464d4333b7b99a24ab045931ba6b276b330038 > Fix error while quitting Fixes #9622
  43. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *be26f501* < https://dev.gajim.org/gajim/gajim/commit/be26f5012086b0d28a70a6db7b07ed0b2fd32383 > Fix nbxmpp method calls features_nb was renamed
  44. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *196d856a* < https://dev.gajim.org/gajim/gajim/commit/196d856a544b92c6e44623ee7acd13a889e04f74 > Remove password before config values
  45. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *c17b7444* < https://dev.gajim.org/gajim/gajim/commit/c17b744465a371731d403f770280f283be7f263a > Generate account label correctly
  46. bot Philipp Hörist pushed 2 commits to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *05dc0044* < https://dev.gajim.org/gajim/gajim/commit/05dc004448407d4e2f80260318ae40eac480bbf5 > Notifications: Check if DBus is available *6ef3b8e0* < https://dev.gajim.org/gajim/gajim/commit/6ef3b8e01b2b01a582125689351e9c5e828a6563 > Windows: Dont steal focus on notification
  47. jonas.baumgardt In which folder are the OMEMO-keys and the message histories saved? Is there a specific folder which I for example can move to another computer to have my OMEMO-keys and my message histories there? I run Gajim on Linux.
  48. bot Philipp Hörist pushed 7 commits to branch _refs/heads/gajim_1.1_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: https://conference.gajim.org:5281/pastebin/00920ff5-6562-44d9-a59e-50150d243e68
  49. lovetox jonas.baumgardt, /.local/share/gajim and /.config/gajim must be transfered to the new pc
  50. jonas.baumgardt My computer doesn't find both paths.
  51. lovetox they should be in your home dir
  52. lovetox ~/.local
  53. mikaela Or if you use flatpak ~/.var/app/org.gajim.Gajim
  54. bot Philipp Hörist pushed 2 commits to branch _refs/heads/gajim_1.1_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *06ca9b39* < https://dev.gajim.org/gajim/gajim/commit/06ca9b39e16549bf230161e3bde766f4b2443586 > Raise nbxmpp version *c972196a* < https://dev.gajim.org/gajim/gajim/commit/c972196a4f25540a2cba30c1d22d9bf334efc571 > Update ChangeLog
  55. jonas.baumgardt lovetox: Okay, now I can find them. But I have one more question: When I copy these folders onto another computer and add my jabber-account in Gajim, will the message histories and the OMEMO-keys automatically be detacted?
  56. lovetox yes
  57. lovetox but i would recommend using the same gajim version
  58. jonas.baumgardt lovetox: Okay, thank you for your quick replies! Have a nice weekend!
  59. lovetox you too
  60. maltel In gajim-plugins/omemo/gtk/key.py:191 (current master): Is there a reason why this doesn't catch all exceptions (my experience with python good practice is small, so that might be why it isn't clear to me). Showing the qrcode is not an essential feature I guess, but like this if there is a problem then the fingerprint window can't be opened...
  61. maltel The reason I ask is because using current master branch of gajim-plugins and gajim, the fingerprint window is not usable on my system. not having qrcode should be cought with the exception, but I have version 5.3, where a ValueError is thrown by PIL.
  62. maltel I tracked the problem down and the issue is that the qrcode package somehow switched the meaning of back_color and fill_color (https://github.com/lincolnloop/python-qrcode/commit/01f440d64b7d1f61bb75161ce118b86eca85b15c) between versions 5.3 and 6.0.
  63. maltel So basically what it got as back_color got interpreted as fill_color and vice versa prior to 6.0. There is a special check for back_color (the internal one) to handle the value 'transparant', but not for the internal fill_color.
  64. maltel Now omemo/gtk/key.py:182 sets back_color to "transparant", which in qrcode versions prior to 6.0 leads to a crash because that is not a valid color for the internal fill_color.
  65. maltel If we could detect what version of qrcode has, then we could just switch the two colors for versions earlier than 6.0, but I don't see a nice way to detect that.
  66. maltel So perhaps catching the problem that happens under version 5.3 and just not showing a qrcode in that case is the most user-friendly solution?
  67. lovetox import pkg_resources pkg_resources.require("qrcode")[0].version
  68. lovetox but yeah this should be easier
  69. lovetox you could also just catch the ValueError at that position
  70. lovetox then try with different args again
  71. lovetox great job working that out :)
  72. lovetox about exceptions, its a fine line, i tend to let gajim show the bug window where people can report the bug rather then silently log it
  73. lovetox because when something doesnt work you waste a lot of time with users telling them how to debug and getting logs
  74. lovetox especially on Windows
  75. lovetox this does also work
  76. lovetox from pkg_resources import get_distribution version = get_distribution('qrcode').version
  77. maltel ah, thanks about the pkg_resources, I tried with __version__ and gi but that didn't work. And I can understand the issue with exceptions, the tracebacks are very useful to have indeed. Should I then try to work out a solution that makes this work with both versions of qrcode and send a pull request?
  78. lovetox this would be great :)
  79. lovetox .
  80. Link Mauve lovetox, asterix, I’m running 1.1.2 and it seems every icon is blurry: https://linkmauve.fr/files/wayland-screenshot-2019-03-16_20-08-53.png
  81. Link Mauve Vertically blurry.
  82. Link Mauve It’s very obvious in the + icon on the left of every group, but also on the Gajim icons.
  83. lovetox what scale do you use?
  84. Link Mauve lovetox, 1.
  85. Link Mauve interface: 'wl_output', version: 3, name: 14 x: 0, y: 0, scale: 1, physical_width: 520 mm, physical_height: 330 mm, make: 'DEL', model: 'DELL 2405FPW', subpixel_orientation: unknown, output_transform: normal, mode: width: 1920 px, height: 1200 px, refresh: 59.950 Hz, flags: current preferred
  86. lovetox scale 1 is no hidpi
  87. lovetox but i guess a gtk/wayland specific problem again
  88. lovetox i could make you a minimal example with a iwndow and an icon
  89. Link Mauve I didn’t experience it on my previous laptop.
  90. Link Mauve Sure.
  91. lovetox Link Mauve,
  92. lovetox https://paste.gajim.org/view/9f64fe56
  93. lovetox is one icon sharper than the other?
  94. Link Mauve lovetox, they both look identical.
  95. Link Mauve And both are properly sharp.
  96. Link Mauve Also scale 1.
  97. lovetox weird then, thats exactly the code we use for icons
  98. lovetox would be interesting if all icons are not sharp in gajim
  99. lovetox or just the roster
  100. lovetox ah you run 1.1.2 ..
  101. lovetox i think it does not have the roster hi dpi icons yet
  102. lovetox hm .. or does it
  103. lovetox nah i does not
  104. Link Mauve I can update to master.
  105. Link Mauve I was using master on my previous computer, before it got stolen.
  106. lovetox oh sorry to hear
  107. bot Malte L proposed a new merge request for _gajim-plugins/master_ < https://dev.gajim.org/gajim/gajim-plugins/merge_requests/118 >: [omemo] Fix fingerprint window for qrcode v. < 6.0
  108. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins >: *2db6d03f* < https://dev.gajim.org/gajim/gajim-plugins/commit/2db6d03fdec1cd36c2b324d670c0c96ecdca2915 > [omemo] Fix fingerprint window for qrcode v. < 6.0
  109. bot Philipp Hörist merged a merge request for _gajim-plugins/master_ < https://dev.gajim.org/gajim/gajim-plugins/merge_requests/118 >: [omemo] Fix fingerprint window for qrcode v. < 6.0
  110. bot Malte L proposed a new merge request for _gajim-plugins/master_ < https://dev.gajim.org/gajim/gajim-plugins/merge_requests/119 >: [omemo] Fix loading of style.css with python 3.5
  111. bot Philipp Hörist updated a merge request for _gajim-plugins/master_ < https://dev.gajim.org/gajim/gajim-plugins/merge_requests/119 >: [omemo] Fix loading of style.css with python 3.5
  112. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins >: *cfaa259a* < https://dev.gajim.org/gajim/gajim-plugins/commit/cfaa259aa74d39dfa564b27b24bbf5ef197aece4 > [omemo] Fix loading of style.css with python 3.5
  113. bot Philipp Hörist merged a merge request for _gajim-plugins/master_ < https://dev.gajim.org/gajim/gajim-plugins/merge_requests/119 >: [omemo] Fix loading of style.css with python 3.5
  114. bot Philipp Hörist pushed 5 commits to branch _refs/heads/master_ of _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins >: https://conference.gajim.org:5281/pastebin/0f163e99-422b-41f2-816c-da8fa046577a
  115. bot Philipp Hörist pushed 6 commits to branch _refs/heads/gajim_1.1_ of _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins >: https://conference.gajim.org:5281/pastebin/cdc77065-947a-4a0d-a195-51054c7dcf35
  116. bot André closed an issue in _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins/issues/386 >: #386: < Problem with pgp plugin in linux flatpak installs >
  117. bot André pushed 2 commits to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *ab6623d7* < https://dev.gajim.org/gajim/gajim/commit/ab6623d7bdd39fb4ebd977b83daf392515ea8c5d > Flatpak: Fix access to GnuPG keys Fixes gajim/gajim-plugins#386 *5af7fbd4* < https://dev.gajim.org/gajim/gajim/commit/5af7fbd42849c6e8c1caf7b5c419ed42a80c6206 > Flatpak: Update dependencies
  118. bot André pushed 2 commits to branch _refs/heads/gajim_1.1_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *4099b01f* < https://dev.gajim.org/gajim/gajim/commit/4099b01f9d0313d530702ef86b248c78524536ed > Flatpak: Fix access to GnuPG keys Fixes gajim/gajim-plugins#386 *65dc8ed8* < https://dev.gajim.org/gajim/gajim/commit/65dc8ed89254a8bec6e8eb0eb31ca0640575ff25 > Flatpak: Update dependencies