Gajim - 2018-10-11


  1. lovetox asterix, the plugin_manager still needs some work, the patch yersteday solved the prob but introduced a new one, plugin_installer in the current version depends on scan_dir_for_plugin loading the plugin without checking if its already loaded
  2. lovetox i think i have to break up that method, scanning for possible plugins, and loading them cannot be in the same method
  3. lovetox sometimes we just want to scan, sometimes we want to scan and load
  4. asterix A load_if_possible option to the function?
  5. asterix I'll read plugin installer code to understand what you mean
  6. lovetox im not sure that make it more pretty, in my opinion the workflow should be the following: 1. Scan for possible Plugins 2. Determine if we want to load them (check version etc) 3. If we want to load them, (new update) first check if old one are loaded and unload them 4. Load the new plugin
  7. lovetox In your MR you removed scan_dir_for_plugins, so im not sure we have that problem anymore
  8. lovetox but the scan_dir_for_plugins does the following now, check if a plugin is already loaded and if so abort
  9. lovetox so you cant install a "new" version of a plugin with that method anymore
  10. lovetox except you unload a previous one first
  11. lovetox which i dont think we do
  12. lovetox also if we want to scan files for specific attributes like GajimPlugin class
  13. lovetox we should use the "ast" module
  14. lovetox instead of loading the module into the namespace, without even knowing if we want to keep it
  15. asterix my current patches do that: https://conference.gajim.org:5281/pastebin/34148c30-5980-410e-aaf6-524963e41e0c
  16. asterix my current patches do that: plugin installer download updates to a new temp folder plugin installer call update_plugins, that install plugins *that are not loaded at all* only (here it's the case: I'm installing a new plugin, not upgrading. For upgrades we only download in a temp folder)
  17. asterix patch in Gajim does that: before trying to load and search any plugin, it copies the files from the temp folder to the user_plugin folder then it loads plugin as it did before (scan_dir_for_plugins is not removed)
  18. lovetox yeah i think that will work, as we dont have the case anymore that we want to update a loaded plugin
  19. lovetox so we should be fine once your patch is pushed
  20. asterix yes, I completly removed the upload / reload module code. if it's already loaded, don't touch it, leave the code in temp folder
  21. asterix so indeed with current plugin_installer code, the plugins that are not compatible with current version of Gajim are not updated :/ we have to improve that
  22. asterix and that will be a roblem for the plugin installer itself. When we'll upgrade Gajim, to 1.1.0, if max_gajim_version is set to 1.0.90, it will not load, so no plugin will be upgraded and none will work. The only solution here is to manualy new plugin_installer, or have plugin_installer shipped with gajim 1.1.0, as we do in our package.
  23. asterix There could be a problem for debian users that manualy installed plugin_installer ... but as they manually installed it, they will have to re-manually install it.
  24. lovetox i think thats what we want or? because plugin_installer 1.0.90 will point to old folder on ftp
  25. lovetox so you install new Gajim, and plugin_installer is shipped
  26. lovetox it gets loaded, and looks at new ftp folder, sees everything is outdated and updates it
  27. lovetox and for people that start from source they know where to get current plugins
  28. asterix yes that's what we want. The only other solution is that plugin_installer for version 1.0 is able to handle the upgrade itself. if gajim.version > 1.0.90, then ftp is there, and you have to d/l to temp folder instead of directly to user_plugin folder
  29. asterix lovetox, additional_data are only available in 1.1? it's not available in 1.0? https://dev.gajim.org/gajim/gajim-plugins/commit/7ad794daebb3d67fe84fdac056ecd23112e135af
  30. asterix this diff really require 1.1 version of Gajim?
  31. lovetox its not about additional data
  32. lovetox yes this plugin uses API that is only in Gajim 1.1
  33. asterix ok, even previous version?
  34. lovetox its about the modules
  35. asterix do I completly remove the plufin from 1.0 branch?
  36. lovetox asterix there are no prev versions
  37. lovetox this is not the old pgpplugin
  38. lovetox that is the nex xep0373
  39. asterix yes I see
  40. lovetox i made this like a month ago
  41. lovetox yes remove it from 1.0
  42. asterix ok
  43. Daniel Not so relevant side-question: what's happening with plugins translation after splitting the plugins repo?
  44. Daniel By splitting I mean to different branches. Is it a problem?
  45. lovetox needs also a new branch in translations
  46. Daniel So right now we habe one: Gajim Plugins. But don't we already have a 0.16 plugins branch and one for master?
  47. lovetox maybe asterix dropped the 0.16 one, it will not get updates anyway so no use in keeping it around
  48. Daniel So in Pootle we would need the 'Gajim Plugins' to reflect current gajim-plugins master, and also add 'Gajim Plugins 1.1' for gajim-plugins branch 1.1? Then it would look the same as Gajim translations on Pootle
  49. lovetox yes
  50. bot Yann Leboulanger pushed 3 commits to branch _refs/heads/gajim_1.0_ of _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins >: https://conference.gajim.org:5281/pastebin/df1486f1-8dba-44df-9806-8fd5dfe6ce36
  51. asterix Yes .. I'll add 1.0 and 1.1 plugins branches in pootle ... and update my scripts ...
  52. asterix Plugins are ready for 1.0 I think
  53. asterix Next step, I prepare them for 1.1 branch
  54. bot Philipp Hörist pushed 1 commit to branch _refs/heads/gajim_1.0_ of _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins >: *ab816c23* < https://dev.gajim.org/gajim/gajim-plugins/commit/ab816c2300921486d3319051c0771151c003a7ea > [hamster] Update manifest.ini
  55. bot heapifyman modified an issue in _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins/issues/352 >: #352: < Plugin Installer update to 0.20.5 fails >
  56. mimi89999 https://blogs.gnome.org/aday/2018/10/09/farewell-application-menus/
  57. mimi89999 Hmmm
  58. bot Philipp Hörist pushed 1 commit to branch _refs/heads/gajim_1.0_ of _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins >: *b7eeed09* < https://dev.gajim.org/gajim/gajim-plugins/commit/b7eeed0941c32b4a97d19070262a8f6e9fc49a54 > [plugin_installer] Update manifest.ini
  59. bot Philipp Hörist closed an issue in _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins/issues/352 >: #352: < Plugin Installer update to 0.20.5 fails >
  60. bot Philipp Hörist pushed 11 commits to branch _refs/heads/gajim_1.1_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: https://conference.gajim.org:5281/pastebin/26d4f8a9-b052-44a5-ab7e-c5950aa6a143
  61. lovetox mimi89999, nothing changes, its just gnome not displaying the menu at the top of the screen
  62. lovetox the menus will still be in the application
  63. bot Daniel Brötzmann updated a merge request for _gajim-plugins/master_ < https://dev.gajim.org/gajim/gajim-plugins/merge_requests/94 >: [omemo] Polish GUI
  64. bot Daniel Brötzmann updated a merge request for _gajim-plugins/master_ < https://dev.gajim.org/gajim/gajim-plugins/merge_requests/94 >: [omemo] Polish GUI
  65. hannibal lovetox: min nbxmpp version in setup.py should be bumped, too
  66. lovetox ah yeah thanks
  67. bot Philipp Hörist pushed 1 commit to branch _refs/heads/gajim_1.1_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *7d507434* < https://dev.gajim.org/gajim/gajim/commit/7d5074347b15b1f1328b169fb9322e9bf97b6fd1 > Raise nbxmpp version
  68. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *f5337c68* < https://dev.gajim.org/gajim/gajim/commit/f5337c6890b119fe03c50881ea889bec57d6ff6e > Raise nbxmpp version
  69. bot Yann Leboulanger pushed 1 commit to branch _refs/heads/gajim_1.1_ of _gajim-plugins_ < https://dev.gajim.org/gajim/gajim-plugins >: *97bdf3fe* < https://dev.gajim.org/gajim/gajim-plugins/commit/97bdf3fe78f206f0cf3b88262cecfd60208c74cc > prepare plugins for 1.1 branch
  70. cippaciong hi lovetox, I think you forgot to update omemo's manifest.ini before releasing 2.6.2
  71. lovetox hm no its fine
  72. cippaciong I guess I was looking at the wrong branch
  73. cippaciong I thought releases only happened on master
  74. cippaciong Is 2.6.20 a typo or is it the intended version number?
  75. lovetox we made a new branch for the upcoming gajim 1.1
  76. lovetox every gajim release will get its own branch of plugins in the future
  77. bot André updated a merge request for _gajim/master_ < https://dev.gajim.org/gajim/gajim/merge_requests/340 >: Fix missing translations problem on flatpak
  78. cippaciong I see, that's nice
  79. cippaciong So is 2.6.2 for branch 1.0 and 2.6.20 for branch 1.1? Just to be sure I create the package for the right version
  80. lovetox yes
  81. cippaciong Ok, thanks
  82. bot André updated a merge request for _gajim/master_ < https://dev.gajim.org/gajim/gajim/merge_requests/340 >: Fix missing translations problem on flatpak
  83. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *8a0ed4af* < https://dev.gajim.org/gajim/gajim/commit/8a0ed4af5bd4ba98cb468a1db5cdba7b74bfe7ea > Fix missing UI translations on flatpak
  84. bot Philipp Hörist merged a merge request for _gajim/master_ < https://dev.gajim.org/gajim/gajim/merge_requests/340 >: Fix missing translations problem on flatpak
  85. bot Philipp Hörist pushed 1 commit to branch _refs/heads/gajim_1.1_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *588e5ede* < https://dev.gajim.org/gajim/gajim/commit/588e5eded749fc884d7e532f18f00e0f3b0d70f1 > Windows: Add correct plugin_installer
  86. bot Philipp Hörist pushed 1 commit to branch _refs/heads/gajim_1.1_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *90a44f61* < https://dev.gajim.org/gajim/gajim/commit/90a44f61e906f819b4114b2220420c39ce67bbd4 > Fix missing UI translations on flatpak