Gajim - 2018-05-08

00:14:53 Citizen Zibb Lol
00:15:04 Citizen Zibb I was a little hasty
04:23:07 bbreezin Not sure if this is expected or not, I'm seeing AttributeError: 'NonBlockingTCP' object has no attribute 'ssl_errors' from connection_accepted() in master
05:45:45 lovetox bbreezin, you have to install nbxmpp from git
05:45:52 lovetox or use a nightly package
05:46:39 bbreezin ahh okay, coded around that issue with try/catch to make it work for now
05:47:48 lovetox pip3 install git+gitcloneurl
05:47:54 lovetox if you dont know that already
05:48:28 bbreezin trying to look into issue #9092, the history mismatch issue. Just looks like the sqlite queries need to be filtering by account_id in the database, but they aren't already
05:49:19 lovetox yes nice issue to start
05:49:27 lovetox should be relativily eas
05:49:29 lovetox easy
05:49:37 lovetox but there is a catch
05:49:59 lovetox the account_id field is only there since gajim_1.0
05:50:31 lovetox so expect that many of these fields come back empty for people that use the same database since 0.16.9
05:51:46 lovetox so the db query must be, accound_id is in (id, empty)
05:52:17 lovetox this is of course not correct sql syntax, just saying
05:53:02 bbreezin gotcha, I should be able to test that case by just removing the account_id field in my database to simulate
05:53:17 lovetox no you misunderstood
05:53:33 lovetox ah no
05:53:44 lovetox if you mean by field, the value in the field its ok
05:54:06 lovetox you dont need to remove the column, it will always be there, because migration adds it the first time someone start gajim 1.0
05:54:10 lovetox it just will be empty
05:54:11 bbreezin I can delete the account_id field in my gajim_1.0 db to simulate an older db, no?
05:54:16 bbreezin oh ok
05:54:18 bbreezin just the values
05:54:52 lovetox and yes thats a good way to test this
05:54:58 bbreezin currently trying to figure out where to get the actual account_id when populating that listview on the history window
05:55:16 lovetox look at the logger.py module
05:55:23 lovetox there we do the db querys
05:55:44 lovetox you have to adjust the db query, than it will automatically return a named tuple that includes the new column
05:55:59 lovetox but ideally the db query gives only back what we query
05:56:07 lovetox so no need to sort that out in the listview
05:56:40 bbreezin but I need to compare to the actual account_id of what should be shown in the history window
05:56:57 bbreezin so I need to know the which account_id the user is asking to see the history of
05:57:13 lovetox let me take a look
05:57:33 bbreezin this would be in history_manager.py I believe
05:59:11 lovetox no history_manager ignore for now
05:59:16 lovetox its based on JIDs
05:59:30 lovetox you cant just filter an account, you would need to add a account selector
05:59:41 lovetox start with the history_window.py
06:00:52 lovetox you can do the whole patch in the logger.py in my opinion
06:01:10 lovetox you find the method that the history_window.py uses to query records
06:01:22 lovetox in the logger.py there is a method called, get_account_id()
06:01:30 lovetox use this to get the account_id from an account name
06:02:13 bbreezin got it, just figured out I actually want history_window.py, now this makes more sense
06:02:56 lovetox get_conversation_for_date
06:03:09 lovetox is the method in logger.py you want to modify
06:03:20 lovetox and it already has the account name supplied
06:05:11 bbreezin yep I see it now
06:07:35 lovetox just to make it a bit more work
06:07:45 lovetox there are various other db calls in history_window.py
06:07:58 lovetox of course all have to take then account_id into considaration
06:08:32 lovetox also if you modify the args of a method call, always grep the whole code base for that methodname, to catch where we use it and modify these to
06:20:59 bbreezin is get_last_conversation_lines() where the last few log lines are loaded into the conversation window into small text?
06:23:54 lovetox yeah i think
06:26:51 bbreezin Yeah it is, adding account_id in that function fixed the messages window
06:31:42 bbreezin like you said, need to think of how to handle it when you click History from the View menu on the main window
06:32:15 lovetox ah
06:32:19 bbreezin looks like it will use account_id = 1 if you have two conversations with the same contact
06:32:20 lovetox becuase we have no account there...
06:32:53 lovetox then make it for now that this window will not filter per account
06:33:54 lovetox this is i guess expected
06:34:24 lovetox the problem is mostly if you select history from within a conversation, that it displays message that have not been in this conversation
06:34:32 lovetox if i select history from view, and type a JID
06:34:40 lovetox it is expected i get everything from this jid
06:34:59 bbreezin Right
06:35:23 bbreezin Right
06:35:29 bbreezin but same window doing both duties
06:35:45 lovetox to be honest this brings us to the next point, why can we even change the jid if we open the window from winthin a conversation
06:36:36 bbreezin Yeah I agree
06:36:43 lovetox its always like that, one leads to anther
06:36:56 lovetox i recommend baby steps and solving one task after another 🙂
06:37:20 lovetox so just fix it that account is taken into consideration when we open from within a conversation
06:37:28 lovetox and the backlog loading for the chatwindow
06:37:42 lovetox afterwards in another MR you can then look into the other things
06:38:02 bbreezin but the History window from the view menu is the same window right?
06:38:54 bbreezin so if it is also using get_conversation_for_date() it'll filter by account when we don't want it to
06:45:33 lovetox bbreezin, but the window is called with other args or not
06:45:48 lovetox the window cant have a value for account, if we call it from the menu
06:46:11 lovetox so if you have no account, you can call another db method, or do another sql query inside the method
06:47:47 lovetox look HistoryWindow is called without account from menu
06:47:50 lovetox so it is None in that case
06:47:59 lovetox so you can know what to do
06:52:57 bbreezin Right
06:53:17 bbreezin Yeah so right now in that case when it is None, it uses info_account, which is the first account
06:53:23 bbreezin so I need to change that behavior
07:09:02 bbreezin Alright, way past my bed time. I will keep thinking on this. Right now when called from the menu with account=None, self.account=info_account, so populating the dates and log data gets done with info_account. We want the dates, and log data to be populated with data from all accounts in that case
07:09:47 bbreezin thanks for the help so far. I will have more questions I'm sure
08:28:31 bot Christoph Erhardt closed an issue in _python-nbxmpp_ < https://dev.gajim.org/gajim/python-nbxmpp/issues/49 >: #49: < python-nbxmpp fails to parse a JID's domainpart expressed as an IP-literal >
09:30:01 pep. > Maranda> lovetox, it happened to me once as well but I was unable to track it down, Link Mauve told me I was spamming with presences the Tatoeba room. Because it was movim@
09:31:22 Maranda pep. What?
09:31:32 Maranda Oh
09:31:47 bosurus Hi, I have a problem to set GUI to german language. Gajim 1.02 on Windows 7. I have set env var LANG to de_DE (and tried other var like LC_ALL etc) but i does not work
09:32:11 lovetox its broken bosurus, we have already a issue about it
09:32:19 lovetox hope to fix it in the next major gajim version
09:33:00 bosurus Thanks. it tried alos to open an issue, but found next problem: I do not get the confirmation email for registring
09:33:32 lovetox thats bad maybe asterix can look into that
09:33:44 lovetox what is your name on gitlab?
09:34:47 bosurus I tried to register as "stephan"
09:36:24 lovetox i activated your account
09:37:54 bosurus Thanks for your help and the info about language selection; I will wait for the new version
10:03:16 asterix lovetox: I didn't know there was a confirmation email ...
10:10:36 lovetox for users who register with their own email
10:10:42 lovetox i would think so
10:13:18 xram Hum, no mam in this conference?
10:21:12 lovetox yes this room has mam
11:53:21 bot Daniel Aleksandersen created an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9117 >: #9117: < Windows UAC dialogs changes status to Not available >
12:45:40 vanitasvitae lovetox: regarding xep-0373, how did you create pgp keys with the userid "xmpp:juliet@example.org"? My gnugp refuses to do that :/
12:46:16 lovetox what command do you use?
12:47:15 vanitasvitae gpg --edit-key
12:47:35 vanitasvitae And then adduid
12:48:00 vanitasvitae It refuses to accept "xmpp:jid@server.tld" as name, mail addtess and comment
12:48:06 lovetox then you are not creating a key..
12:48:52 lovetox i dont do this so i dont know
12:49:08 lovetox but its probably possible
12:49:15 lovetox gnupg just defaults to a behaviour
12:49:21 lovetox but im sure you can overwrite this
12:50:15 vanitasvitae > then you are not creating a key.. The same dialog comes when creating a key
12:50:25 vanitasvitae It doesnt work at creation time either
12:50:59 vanitasvitae > i dont do this so i dont know > but its probably possible Afaiu it is mandatory in xep-0373, so we should find a solution :D
12:51:42 lovetox its not mandatory to give the user the ability to edit existing keys
12:52:15 lovetox --gen-key allows for providing a dict like input file
12:52:29 lovetox which overwrites gnupg behaviour
12:53:03 lovetox https://www.gnupg.org/documentation/manuals/gnupg/Unattended-GPG-key-generation.html
12:53:39 vanitasvitae Ah I'll look into that
12:54:12 vanitasvitae > its not mandatory to give the user the ability to edit existing keys But it is mandatory, that keys used in the context of 373 do have a uid attribute with xmpp:jid@server
12:54:32 lovetox yes, and thats what i do
12:54:48 lovetox but im not editing existing keys of users for that
12:55:17 lovetox i generate a new key for use with xmpp
12:55:45 lovetox you should really think this through if you planning to let users add their own keys
12:56:24 vanitasvitae Yeah I'll consider that
12:56:32 lovetox stuff like blind trust before verification needs many trust changes to the keyring
12:56:54 lovetox if a user lets you use his main pgp key, he will not give you his password
12:56:59 lovetox meaning you have to use a agent
12:57:09 lovetox meaning he gets prompted everytime a new key is received
12:58:22 lovetox or he has to configure his agent that he is not prompted on EVERY change
12:58:36 vanitasvitae Which uid parameter do you provide? Name, mail or comment?
12:58:42 lovetox which means he gives the application basically access to his whole keyring
12:59:22 vanitasvitae I think the best solution would be to auto generate a key and give the user the ability to sign it with his own key.
12:59:40 lovetox params = { 'Key-Type': 'RSA', 'Key-Length': 2048, 'Name-Real': 'xmpp:%s' % jid, 'Passphrase': passphrase, }
12:59:53 vanitasvitae Okay
12:59:58 vanitasvitae Thank you :)
13:26:14 vanitasvitae Ah, generating the keys unattended worked :)
15:36:54 bbreezin is the list app.contacts.get_accounts() always indexed as (account_id - 1) as in the account_id stored in the log database?
15:38:15 bbreezin I'm asking if I can use the account_id in the database to lookup the account with .get_accounts()[] to get the account nickname
15:42:26 lovetox no breezin
15:42:34 lovetox that gets you a list of all accounts
15:42:42 lovetox but you can delete accounts
15:42:51 lovetox so the index of a account can be 100
15:43:00 lovetox if you deleted 99 accounts before
15:43:49 lovetox account_id is a database thing, you should not introduce it anywhere else than in the logger.py
15:44:14 lovetox and there you can convert a account name to a id with the appropriate method
15:52:56 bbreezin Ahh, need to get from account id in the messages to the nickname in the _add_message() function
15:54:47 bbreezin add_message() in the HistoryWindow
15:55:26 lovetox why?
15:57:11 lovetox the nickname of what?
15:57:29 bbreezin The case where I have a conversation with contact C with both my accounts A and B. In the history window from the View menu, we want to show all messages with contact C
15:57:54 bbreezin so I want the prefix to every SENT message (my nicknames) to show the correct account A or B nickname
16:01:27 lovetox this is already done in add_message
16:02:04 lovetox just look how it determines contact_name
16:04:05 bbreezin you're talking about the if self.account:
16:04:22 bbreezin self.account is always defined. Even when launched from the View menu
16:05:58 bbreezin even if self.account was None in that case, it would just use the nickname from the first account in app.contacts.get_accounts()
16:06:42 lovetox ok so you get account_id from the database and want to translate it to a account name
16:07:30 bbreezin Right, each message object passed into add_message() as an account_id field
16:08:05 bbreezin I want to use it, and if the account_id is blank, I will default to using the name of the first account from app.contacts.get_accounts()
16:08:12 bbreezin has an*
16:10:58 lovetox ok let me thing about it whats the best move here
16:14:18 bbreezin No problem. In _load_history(), I had to loop through all accounts in app.contacts.get_accounts() when the window is opened from the View menu for the purpose of running the get_first_date_that_has_logs() and get_last_date_that_has_logs() functions. The first or last messages could be stored in either account that messaged the contact.
16:14:32 bbreezin Does that sound like a valid method to you?
16:23:12 lovetox hm no i dont think i understand this
16:23:17 lovetox if there is no account supplied
16:23:25 lovetox then it should not be in the db query
16:23:41 lovetox so you get the first date that has logs, and dont have to care about the account
16:25:20 lovetox the account has to be supplied to get_last_date_that_has_logs() because of the metacontacts hm
16:25:40 lovetox so we could just pass a list of accounts, and gather all the familiy jids from all accounts
16:25:41 bbreezin but the logger.py functions, get_first_date_that_has_logs and get_last_date_that_has_logs require accounts
16:26:56 bbreezin Right, so either iterate through an account list in HistoryWindow, making multiple calls to the logger functions, or pass a list of accounts to the logger function and have it do the checking
16:27:16 lovetox the second one
16:27:31 lovetox the account is only need to gather a list of jids that will be taken into account
16:27:53 lovetox goal would be to do only one db query
16:27:55 lovetox not multiple
16:28:10 lovetox so loop over get_family_jids, acquire all jids
16:28:13 lovetox then do one db query
16:28:28 bbreezin Gotcha, so essentially pass the result of app.contacts.get_accounts() to the logger.py call
16:29:09 lovetox i think this would be correct
16:29:35 bbreezin Okay, I'll work on that. Like you said....this small issue has snowballed into a lot more work than it first appeared to be lol
16:30:03 lovetox yeah quite complex now
16:30:52 lovetox though im really overthinking if we need that view -> history window call
16:31:08 lovetox it seem to be redundant if you look at the history manager
16:31:11 lovetox which does the same
16:32:04 bbreezin The history manager doesn't have the calendar selector or anything though
16:34:30 bbreezin I think eventually it might not be a bad idea to have an "account" drop down in the history window to only show messages from the account you select, or the option for all accounts, but all this current work will be the basis for selecting the "show all accounts" option
16:43:07 lovetox i will add a method that gets you the account from the id
16:43:15 lovetox do you know how you rebase your work?
16:56:33 bbreezin Yeah I've added an upstream remote
16:57:50 Maranda rebasing that strange thing
17:20:23 bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ < https://dev.gajim.org/gajim/gajim >: *2bb5d55c* < https://dev.gajim.org/gajim/gajim/commit/2bb5d55c03941642cf03f72792b1550ee69698e0 > Add conversion from account_id to account jid To use this alias `account_id` with `account` Example: SELECT account_id as account FROM logs
17:20:41 lovetox there you go bbreezin ^
18:02:02 bbreezin Got it, I'll dig into this later. Thanks lovetox
19:14:19 marc I get this error message on Ubuntu: E: Repository 'ftp://ftp.gajim.org/debian unstable InRelease' changed its 'Origin' value from '' to 'Gajim'
19:14:21 marc What's wrong?
19:20:05 asterix I indeed changed origin ... nothing wrong
19:27:21 marc asterix, okay, thanks
20:14:09 bot Daniel modified an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9117 >: #9117: < Windows UAC dialogs changes status to Not available >
20:15:11 bot Daniel modified an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9114 >: #9114: < group chat makes gajim segfault in glib >
20:19:18 bot Daniel modified an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9113 >: #9113: < Gajim on OpenBSD gives error when connecting >
20:22:34 bot DorKeinath created an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9118 >: #9118: < gajim-nightly problem with gir1.2-gtk-3.0 or 3.10.8~8+qiana >
20:24:21 bot Philipp Hörist closed an issue in _gajim_ < https://dev.gajim.org/gajim/gajim/issues/9118 >: #9118: < gajim-nightly problem with gir1.2-gtk-3.0 or 3.10.8~8+qiana >