Gajim - 2017-08-27

  1. ivtq How do I disable notifications from pubsub?
  2. lovetox not sure what you mean
  3. lovetox to get notifications you have to subscribe i think
  4. lovetox did you do that?
  5. ivtq Is it possible to disable pubsub notification, if the xmpp account I signed up for them?
  6. lovetox no
  7. Asterix lovetox: antispam plugin has that feature if I understand what he want
  8. lovetox oh i didnt know
  9. lovetox indeed
  10. cippaciong lovetox: hi :) I saw that you have released a new version of omemo but you forgot to create the git tag
  11. lovetox sorry im on it
  12. lovetox cippaciong, done
  13. cippaciong Thanks, this way to release new versions is very helpful ^^
  14. marc lovetox, Hi, have a patch for httpupload to use the max-file-size information in the error message instead of using the server error message. Are you interested in this?
  15. lovetox yes, please do a MR
  16. lovetox though where is the difference between those two?
  17. marc lovetox, okay nice, I'm not on my dev PC but will do later
  18. marc lovetox, well, the error may vary between servers and we can not do translation
  19. marc the information is in bytes etc.
  20. marc very ugly
  21. lovetox hm ok :)
  22. marc The patch uses the server response as fallback
  23. cippaciong I'm trying to run gajim-git installed from AUR but fails with this error: "ImportError: cannot import name 'NS_JINGLE_FILE_TRANSFER_5'"
  24. cippaciong Is it a known bug?
  25. cippaciong bug or misconfiguration on my side of course
  26. Link Mauve cippaciong, you probably forgot to install a recent python-nbxmpp.
  27. cippaciong 0.5.6-1
  28. cippaciong is the latest tag on git
  29. Link Mauve You need the latest master, just like you are using the latest master of Gajim.
  30. Link Mauve They are generally released in lockstep.
  31. cippaciong Ok, installing it right now. Why not use the -git version as a dependency for gajim-git then?
  32. Link Mauve Good question, let me fix that.
  33. cippaciong Thanks ☺
  34. Link Mauve cippaciong, fixed, and pushed to AUR.
  35. Link Mauve Thanks for the report. :)
  36. cippaciong Thank you
  37. concerto Gajim master branch - text smileys are being rendered as emojis in Gajim...and rather ill-suited ones at that.
  38. concerto For instance, :D should be 😃 but 😂 is displayed instead.
  39. concerto Similarly, :) should be ☺️ but 😊 is displayed instead.
  40. concerto Perhaps Gajim can sidestep the this and just render text smileys as they are, and use (explicitly entered) emojis separately? Possibly moving this out into a plugin if desired.
  41. bot Yann Leboulanger pushed 1 commit to branch _refs/heads/master_ of _gajim_ <>: *46c9e5c6* <> Make IPython 5 work
  42. Asterix the only pylint errors are in dataforms. see:
  43. Asterix if someone has an idea ...
  44. Asterix pylint doesn't understand that at line 11 we define a property, he sees a function. So when we do at line 21 self.t = xxx he thinks it's an error
  45. lovetox Asterix you can disable pylint errors in certain files, or even just for a few lines
  46. lovetox concerto, where do you get this knowledge what text smilie should be what emoticon
  47. Asterix probably ignore some file with the ignore parameter
  48. lovetox no Asterix, you can in code ignore one specific error for 3 lines
  49. Asterix haaa
  50. lovetox # pylint: disable=E1101
  51. Asterix # pylint: disable=E1101
  52. concerto lovetox, visual comparison. But it's *because* it can be difficult or too subjective beyond some emojis that I suggested leaving text emojis as they are.
  53. Asterix yesexactly
  54. lovetox for example, just place this as comment somewhere
  55. lovetox concerto, its not an option to render text smilies as text, because nobody wants that
  56. lovetox and i dont get what you mean by visual comparison
  57. lovetox yes emoticons are subjective, thats why on every phone OS they look totally different
  58. concerto lovetox, Conversations does it that way, and I sure don't mind. :) In the two examples above the "should be" ones are very clearly more similar to the text than the current ones.
  59. concerto That's what I meant by visual comparison.
  60. lovetox im not against changing them, just are you aware that tomorrow someone else comes and tells me he things we should change that again
  61. Link Mauve “20:23:05 Asterix> if someone has an idea ...”, why do you do that dance instead of using property directly?
  62. Asterix Link Mauve: see dataforms for a real example. gset and fget are not that simple
  63. Asterix Link Mauve: see for a real example. gset and fget are not that simple
  64. lovetox and because conversations does it that way is not really a good answer
  65. lovetox :)
  66. bot Yann Leboulanger pushed 1 commit to branch _refs/heads/master_ of _gajim_ <>: *b4362a8a* <> ignore some pylint errors
  67. Link Mauve Asterix, but why fget/fset/fdel instead of the @property?
  68. Asterix it was done this way by the guy who did it. this nester property is to simplify things. His comment was: # helper decorator to create properties in cleaner way
  69. concerto lovetox, there's another principle - don't modify user input.
  70. Link Mauve Maybe he didn’t know about @property?
  71. lovetox concerto, as good as all application render text smilies as emoticons
  72. lovetox chat applications
  73. Asterix Link Mauve: I doubt it. If he can create a property, he must know about that
  74. Asterix but yes, maybe using the @property is a solution
  75. Asterix ha and the not-callable error with the _ is still here
  76. Link Mauve From 701e7bec7854d9ff012703ac0483d01da5e21b36 Mon Sep 17 00:00:00 2001 From: Emmanuel Gil Peyrot <> Date: Sun, 27 Aug 2017 20:41:27 +0100 Subject: [PATCH] dataforms: Simplify type_ to use @property directly. --- gajim/common/ | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/gajim/common/ b/gajim/common/ index 8747fc193..1ac03eac4 100644 --- a/gajim/common/ +++ b/gajim/common/ @@ -131,25 +131,23 @@ class DataField(ExtendedNode): self.required = required self.options = options - @nested_property - def type_(): # pylint: disable=E0202 + @property + def type_(self): """ Type of field. Recognized values are: 'boolean', 'fixed', 'hidden', 'jid-multi', 'jid-single', 'list-multi', 'list-single', 'text-multi', 'text-private', 'text-single'. If you set this to something different, DataField will store given name, but treat all data as text-single """ - def fget(self): - t = self.getAttr('type') - if t is None: - return 'text-single' - return t - - def fset(self, value): - assert isinstance(value, str) - self.setAttr('type', value) + t = self.getAttr('type') + if t is None: + return 'text-single' + return t - return locals() + @type_.setter + def type_(self, value): + assert isinstance(value, str) + self.setAttr('type', value) @nested_property def var(): # pylint: disable=E0202 -- 2.14.1
  77. Link Mauve Asterix, like that ^
  78. Link Mauve I can do it for the rest too.
  79. lovetox are you going to test than all cases where we use dataforms and if they still work=?
  80. Asterix Link Mauve: yes ok sounds nicer indeed
  81. Link Mauve lovetox, what is there to test?
  82. Link Mauve Do you have tests for that part?
  83. lovetox no thats the point, its now working :)
  84. Asterix what is not working?
  85. lovetox read again
  86. Asterix now ...
  87. concerto lovetox, oh, hey, one could even make it user-modifiable :>
  88. concerto I mean, if someone *really* wants to...
  89. Asterix
  90. Link Mauve lovetox, I already found a bug thanks to that change. ^^
  91. Link Mauve So, well…
  92. Link Mauve And a second bug.
  93. lovetox concerto, actually not that easy with current code
  94. Link Mauve So no, I don’t believe that things are working currently.
  95. concerto lovetox, ow :(
  96. lovetox but i agree on the normal smilie
  97. lovetox i change that later
  98. lovetox :)
  99. Link Mauve And so,
  100. Asterix Link Mauve: and what are the bugs you found ?
  101. Link Mauve Asterix, some missing (self) and some with too many arguments (self, value) while it was a deleter.
  102. Asterix yes, this one I had it to commit
  103. Link Mauve You can just merge mine, it fixes it too.
  104. bot Yann Leboulanger pushed 2 commits to branch _refs/heads/master_ of _gajim_ <>: *63947c42* <> dataforms: Replace @nested_property with @property. *aa087c34* <> Merge branch 'dataforms' into 'master' Replace @nested_property with @property in dataforms See merge request !124
  105. Asterix and what do you think about 123?
  106. Link Mauve :)
  107. Link Mauve Looks nice.
  108. Link Mauve Only one minute 31?
  109. Link Mauve Is your server extremely fast?
  110. Asterix not that bad
  111. Asterix Xeon(R) CPU E3-1220 V2 @ 3.10GHz
  112. Link Mauve Hmm, not significantly faster than my laptop, which got something like six minutes the last time.
  113. Asterix yes
  114. Asterix but we don't test the same things!
  115. Asterix I only test errors, and not all
  116. Link Mauve Oh, I see. :)
  117. bot Yann Leboulanger pushed 2 commits to branch _refs/heads/master_ of _gajim_ <>: *915ad152* <> add pylint run to CI *c862ecd8* <> Merge branch 'master' into 'master' add pylint run to CI See merge request !123
  118. Asterix any obection to 122?
  119. Asterix lovetox: ?
  120. lovetox i wanted to ask you the same
  121. lovetox for me this is good enough
  122. lovetox on win and mac we get the best info we can get
  123. lovetox on Linux, we get "Linux" and if the distro package is installed, the best info we can hope for
  124. lovetox i find this better then trying ourself on 56 distros to get some info somehow
  125. Link Mauve Sounds sensible.
  126. Link Mauve Should I make distro a dependency or an optional dependency of the package in ArchLinux?
  127. lovetox its just for the Version Request xep
  128. Link Mauve I know, but it’s just 172 KiB of dependencies.
  129. lovetox then do it :)
  130. lovetox you are the package maintainer on that one, i guess you decide what your users need and what not :)
  131. Link Mauve Yeah.
  132. Asterix it's optional for Gajim ...
  133. bot Yann Leboulanger pushed 2 commits to branch _refs/heads/master_ of _gajim_ <>: *66b49c24* <> common.helpers: simplify get_os_info() *d6a8a238* <> Merge branch 'os_info' into 'master' common.helpers: simplify get_os_info() See merge request !122
  134. Asterix we should update the README for optional dep
  135. Link Mauve Asterix, but the difference is whether it will be installed alongside, or if the user will have to install it manually.
  136. Asterix he won't, he can't guess we optionnaly depend on it
  137. Link Mauve No I mean, I’m the packager, I get to choose.
  138. Asterix on debian it's only 58.4 kB once installed
  139. Asterix yes I know
  140. Asterix ha yes you can list it in optional dep ..
  141. Asterix ok ok I go rest :)
  142. Asterix CU
  143. Link Mauve \o_
  144. Link Mauve lovetox, did you do any progress towards removing python-dbus btw?
  145. lovetox not even looked into it, im trying to redesign the account window, so it looks more modern reight now
  146. Link Mauve also points to an empty page now, in addition to not having a certificate.
  147. Link Mauve Nice. :)
  148. lovetox this will probably take me another week
  149. lovetox where do you get the link?
  150. Link Mauve In gajim/common/
  151. Link Mauve Grepping for also gives a bunch of links that should be updated.
  152. lovetox oh i have to change that
  153. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <>: *2e1c1062* <> Update ascii smilies
  154. lovetox concerto, here you go
  155. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <>: *298fa4b9* <> Update old trac links
  156. Link Mauve lovetox, I think you forgot a slash on line 97 there.
  157. lovetox why do you think?
  158. lovetox i pasted it like its in the browser
  159. lovetox ah i understand
  160. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <>: *ec1d75f1* <> Fix typo in link
  161. lovetox i should clean up that acronym expander plugin
  162. lovetox and put it into the repo its quite useful
  163. concerto lovetox, thanks! :D
  164. concerto lovetox, any idea why password manager autotype wouldn't work in master branch Gajim but did in nightly? (GTK? The password manager here (passwordsafe) uses wxwidgets AFAIK)
  165. concerto profile image (set in Conversations) doesn't seem to appear in Gajim.
  166. Link Mauve concerto, Conversations uses the WebP format which isn’t supported anywhere else.
  167. Link Mauve Set your image from Gajim for maximum compatibility.
  168. lovetox you dont save your password, and your password manager fills it in on start?
  169. lovetox is this the application?
  170. concerto lovetox, yeah (not automatically, I have to unlock it and double click the entry), and yeah.
  171. lovetox ok i will install and test this
  172. Link Mauve lovetox, it was easier than planned:
  173. mathieui only deletions?
  174. Link Mauve Nope, I also added a new implementation based on Gio.
  175. Link Mauve Which is a whopping five lines.
  176. Link Mauve Oh, GitLab helpfully collapsed the main file…
  177. mathieui right, gitlab collapsed that file
  178. lovetox GNotifications are not implemented on windows, so i have to see what and if we still have a fallback
  179. Link Mauve Oh, I removed all fallbacks.
  180. lovetox thats what i was about to check ^^
  181. Link Mauve Isn’t it easier to upstream your fallback into Gio?