botYann Leboulanger pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>:
*2b065c0e* <https://dev.gajim.org/gajim/gajim/commit/2b065c0e58fec0ce691c9501fcb33f94da9ca000>
remove unused import / variable
lovetoxi think i found the reason
lovetoxthere is a pylint.rc file in the gajim folder
botPhilipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>:
*b9363fe9* <https://dev.gajim.org/gajim/gajim/commit/b9363fe9838c792e1e75f4ed038f11bf88f7f598>
Remove pylint.rc from gajim folder
lovetoxhm no does still not work
mimi89999How can I see if my contact read a message in Gajim?
andrey.gmimi89999: I guess it is still impossible: "Support XEP-0333: Chat Markers" https://dev.gajim.org/gajim/gajim/issues/8163
andrey.gAnd even delivery receipts were disabled: "Dont show warning on missing 0184 receipt" https://dev.gajim.org/gajim/gajim/commit/42dba38b5e8bace143b0ae1b7459743f42c457d3 :(
andrey.gAha, there is "positive_184_ack" in ACE. Let's try...
mimi89999Isn't it about me sending them?
andrey.gI don't know for sure, but usually XEPs describe the behavior for both directions.
Asterix184 tell that the contact's client received the message, not sure it has been read / understood
botPhilipp Hörist pushed 2 commits to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>:
*663176cf* <https://dev.gajim.org/gajim/gajim/commit/663176cfc5408d1161943564504c5a10fbb517cb>
fix some import warnings and errors pointed out by pylint
*94cbccec* <https://dev.gajim.org/gajim/gajim/commit/94cbccecb174d4aabf3454a75a52977eceefb08e>
Merge branch 'imports' into 'master'
fix some import warnings and errors pointed out by pylint
See merge request !121
andrey.gAsterix, yes. For me 184 is much more important than 333.
lovetoxandrey.g, 184 still works in gajim better than ever
lovetoxbut its still not what you want, and it will never be what you want
andrey.glovetox, yeah. BTW, I thought, that 184 has been removed because IIRC warnings were showed by default, but now positive acks are not showed by default.
lovetoxwhat do you mean by default
lovetoxthis setting was never enabled by default, as its privacy related
lovetoxhm no that makes no sense actually
lovetoxwe should show the positive ack by default
lovetoxthis setting probably only exists because people wanted a way to turn of the red X all the time
lovetoxbut now that its gone i see no reason to not show the positive ack by default
lovetoxat least until gajim has something like readmarkers
andrey.gI don't see the setting for disabling red X.
lovetoxits the same setting
lovetoxshow positive ack, means show receipts
lovetoxactually that only the internal name for it
lovetoxthe user has the option "Notify by icon when your messages are received"
lovetoxwhich is clear enough
andrey.g> its the same setting
I'm not sure. Before I always had them, now not, because positive_184_ack was disabled.
lovetoxyou dont see red X because its removed from Gajim
lovetoxand positive ack = show receipt icons
lovetoxwhich is disabled by default, it was always like that
lovetoxbut we can make it on by default
andrey.g> i see no reason to not show the positive ack by default
Agree and especially, because gajim asks for them unconditionally (e.g. commit "Always send message delivery receipts requests"), so why then ignore them? Thus it would be even better to check this config before querying for them.
lovetoxyou misinterpreting commits
lovetoxAlways meant of course only if the user wants
lovetoxbut before we even then did not always request it
lovetoxthis was regarding offline contacts
andrey.glovetox, I mean that showing red X was not regulated by positive_184_ack as you said.
lovetoxwhere we didnt request receipts
lovetoxi think it was
lovetoxpositive ack means show receipt icons
lovetoxin the past it meant show red x when we dont get one
andrey.g"Always" I mean that not depending, whether the user want them to be displayed. No display - no need to ask for them.
lovetoxyes i agree
lovetoxthe setting is now useless
lovetoxbut just to be clear, thats not the setting that regulates if we request receipts
lovetoxit just if we show them
andrey.g> at least until gajim has something like readmarkers
I vote to keep pos. 184 acks even after readmarkers come.
andrey.gYes.
andrey.gAt least now.
lovetoxi did not mean to remove them, as the marker xep can not compensate the 184 xep
lovetoxbut it maybe influence the default on what we show
andrey.gThen good.
lovetoxif you can get the information if someone read the message, its not needed to show you that its received
andrey.gYes, once readmarker is received it could just replace the 184 one.
lovetoxbut of course these are minor things that can be discussed to find sensible defaults
botYann Leboulanger pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>:
*e57817ad* <https://dev.gajim.org/gajim/gajim/commit/e57817addc344e7c06446e394abe5fd68fe24301>
Nicer code
mimi89999lovetox: Shouldn't be hard to show that message was read...
lovetoxit probably would not, but at the moment instead of adding new features i try to conectrate on refactoring
lovetoxas the codebase is really old and needs some updates
mimi89999lovetox: Do you think I could try to implement it?
mimi89999lovetox: I think moving the read status might be a bit difficult. Will it be?
mimi89999I mean in the chat window.
lovetoxi would not move anything
lovetoxwe add a mark in the textview, the name of the mark is the stanza id
lovetoxwhen a receipt comes we grab the mark and insert the symbol
lovetoxso if now another read receipt comes, you would grab the mark again
lovetoxdelete one char to the left
lovetoxand insert the new symbol
lovetoxbetter not delete the received mark
lovetoxinstead add the second symbol besides
lovetoxbecause when the next read receipt comes you have to delete the previous one
lovetoxbecause you dont get for every message a read receipt only for some, we should only display the last
mimi89999lovetox: It was what I mean
mimi89999lovetox: If I send 2 messages and get a read for one and then for the other, we should only display read for the last one... So the previous read would be removed...
mimi89999I have no clue how to add that...
mimi89999I know Python...
lovetoxmimi89999, in the time i would need to guide you through this i could probably do it myself. i have a branch where i began to implement it, maybe wait a few weeks and i have time to finish it
mimi89999lovetox: Which one?
mimi89999(branch)
Asterixhmm this is perfectly valid code: https://paste.gajim.org/view/296b4e97
but pylint return an error:
E: 11, 4: An attribute defined in ttt line 21 hides this method (method-hidden)
Asterixwe don't hide the d() method here
Asterixhow can I prevent pylint from raising that error without disabling E0202?
botYann Leboulanger pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>:
*8d4e815f* <https://dev.gajim.org/gajim/gajim/commit/8d4e815f3eff74c237cd8ef0ff22306c64b21256>
fix some pylint errors
botYann Leboulanger pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>:
*134f72db* <https://dev.gajim.org/gajim/gajim/commit/134f72db173d1f1ef7e4061226dd0c150aaf667e>
Hide some pylint errors