Gajim - 2017-08-23


  1. Link Mauve Wow, six minutes to generate a total of 23115 lines of report.
  2. Link Mauve Your code has been rated at 6.33/10
  3. bot Yann Leboulanger pushed 2 commits to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *de05dab6* <https://dev.gajim.org/gajim/gajim/commit/de05dab680563d95ccb492ddba78743e7d5ed18b> pylint: Ignore a few useless warnings. *1750217e* <https://dev.gajim.org/gajim/gajim/commit/1750217e7fa7a4f1424b7de2437617c47698023f> Merge branch 'pylint' into 'master' Ignore a few useless warnings in pylint See merge request !120
  4. Link Mauve Only 1794 actual errors, and not warnings or convention issues.
  5. Link Mauve Not too bad.
  6. Link Mauve Oh, the setattr(self, key, value) pattern isn’t recognised.
  7. Link Mauve Second error I check is an actual bug waiting to be triggered…
  8. Link Mauve I have no idea how the ipython thing can even work.
  9. Link Mauve How do you enable it?
  10. Link Mauve Oh, I’ve reproduced the roster bug!
  11. Link Mauve Start Gajim with one account enabled, enable a second one, connect it, and voilà.
  12. Asterix I never said it's useless!! I said I don't have time to configure it correctly so that it's usable
  13. Asterix if I set that to pre-commit, there won't be any commit anymore in Gajim
  14. Asterix we know how to repro
  15. Asterix the roster bug
  16. Asterix but we don't know how to fix it
  17. zb hey guys, quick question: is there a possibility in gajim to have the used device displayed für each message? as in [contact]/[device] or something?
  18. lovetox zb not to my knowledge
  19. lovetox Link Mauve, until last week pylintrc did not work, because the gajim folder was not a package
  20. lovetox at least for me in my IDE
  21. lovetox but now it is, and i will refine it, so we get down to real errors
  22. Link Mauve lovetox, oh, in my IDE it was running fine as long as I started it with src as a parameter.
  23. Link Mauve (I use zsh as my IDE. :p)
  24. mimi89999 lovetox: What is still in the TODO before making nightly stable?
  25. lovetox fix one bug with the roster
  26. lovetox but its hard to track down
  27. bot Philipp Hörist pushed 2 commits to branch _refs/heads/master_ of _gajim-plugins_ <https://dev.gajim.org/gajim/gajim-plugins>: *e69d59e8* <https://dev.gajim.org/gajim/gajim-plugins/commit/e69d59e80b45faa59a5c460c198c2cf38c8d366c> [omemo] Remove needless stream.close() This is only a BytesIO Object in memory, its becomes garbage collected after the method ends anyway Fixes #232 *916c2db9* <https://dev.gajim.org/gajim/gajim-plugins/commit/916c2db9862fb40163e64a250a0ff67de40ce5a9> [omemo] Update CHANGELOG & manifest.ini
  28. mimi89999 Maybe with more users you will have more reports?
  29. lovetox we dont need more reports, we can reproduce the bug
  30. lovetox its just a complicated part of gajim, which needs a lot of time to find out whats wrong
  31. mimi89999 How can I reproduce it?
  32. lovetox add a group, place one contact in it that is offline
  33. lovetox disable showing offline contacts
  34. lovetox you should not see the group
  35. lovetox when the contact comes online, the group an contact shoulb become visible, instead nothing happens, and on some systems gajim crashes
  36. lovetox and the problem with the mesage text input is totally a gtk bug
  37. lovetox i have to report it and hope they fix it, because working around it is a lot of work
  38. bot Philipp Hörist pushed 8 commits to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *00e72b1d* <https://dev.gajim.org/gajim/gajim/commit/00e72b1d739666a0f6cf741747e8e612e850d6b7> Remove unused code Whatever this was, its not used since 4 years see 8f71d9f21955d30cd47fabdf0b95869603887cb9 *44a28770* <https://dev.gajim.org/gajim/gajim/commit/44a287703e9ab39c5d51d13bf8e807cefc36674a> Fix method call Regression from making gajim a module *b72c3c10* <https://dev.gajim.org/gajim/gajim/commit/b72c3c109c5862a845f85847012008d57d555db9> Remove unused event handler There exists no 'default_status_eventbox' anymore in Gajim *80e5c27f* <https://dev.gajim.org/gajim/gajim/commit/80e5c27fa9dfba4f1328c5ff73dc598fe8339810> Use correct inherit pattern *6cacc559* <https://dev.gajim.org/gajim/gajim/commit/6cacc559018dcf15f20d7c1d36ca0bcf82b07d13> Dont use internal members in Dialogs vbox and action_area are internal members of Gtk.Dialog. We should use the methods provided by the API to get these Objects. *4a9ba28a* <https://dev.gajim.org/gajim/gajim/commit/4a9ba28a10ea0ca6a16aca473b9352ca636ac0a3> Fix typo *26dda615* <https://dev.gajim.org/gajim/gajim/commit/26dda615557fcf65a3839970c058e366d0b2d79f> Fix undefined-variable *95f4703d* <https://dev.gajim.org/gajim/gajim/commit/95f4703de270caba853c133aa6ac47290b230098> Fix unexpected-keyword-arg
  39. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *00d091dd* <https://dev.gajim.org/gajim/gajim/commit/00d091dd548436900ec04354f69a1a2104be1a4d> Add keyword arg to prototype this was probably forgotten
  40. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *28045e9d* <https://dev.gajim.org/gajim/gajim/commit/28045e9d36b2061a7949d77bda98cc8120279a12> Resolver: Raise correct error
  41. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *1a352c0e* <https://dev.gajim.org/gajim/gajim/commit/1a352c0e4723acd345b20a24334bd3fa76fb8781> Zeroconf: Call method with correct arguments
  42. Asterix Link Mauve: why does pylint report that: _ is not callable (not-callable) while we use --additional-builtins=_
  43. Link Mauve Not sure, let me try.
  44. lovetox Asterix, it reports it only in the other modules, like common and command_system
  45. lovetox it doesnt report it in the gajim package
  46. lovetox i think the rc file is maybe not valid for the submodules or something like that
  47. Asterix I don't use rc file here
  48. lovetox at least when you specify it on command line, but still weird
  49. lovetox if you dont use a rc file
  50. lovetox then pylint will search for one until it finds one
  51. lovetox that means it will use the one in the root dir
  52. lovetox hm but still all the more reason to not show the error
  53. Asterix Link Mauve: you can run that to see them: pylint3 --disable=all --enable=E1102 --additional-builtins=_ gajim
  54. lovetox Asterix, are we sure --additional-builtins works
  55. lovetox its not mentioned under --help
  56. Asterix it is under --long-help
  57. Link Mauve Asterix, indeed, it fails here too, for modules not in the gajim package.