Gajim - 2017-07-31


  1. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *81566df8* <https://dev.gajim.org/gajim/gajim/commit/81566df8a1f988c5820309ec2865b8ced895fc8f> Fix some regressions with MAM - On single messages use the bare JID for DB querys - Add more debug logging - Some light refactoring
  2. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *850e2736* <https://dev.gajim.org/gajim/gajim/commit/850e273605d842f4681d75505d89a7cd9e0b286c> Correctly remove timeout source Set source IDs to None after removing the source except when shutting down, because the Control ist destroyed anyway Only try to remove if we have a source ID
  3. Link Mauve lovetox, again for your last commit, you should use “is not None” instead.
  4. lovetox yeah it just seems so wasteful :/
  5. lovetox i mean why only with None? you can do that in every if condition ask exactly for the value you search
  6. lovetox if this is True, and this is False
  7. lovetox this makes the code more verbose
  8. Link Mauve Because None is a singleton, you want to check against it by pointer address instead of doing a costly RichCmp.
  9. Link Mauve “if something:” actually means “if bool(something):”, and is way more costly.
  10. SaltyBones O_o
  11. SaltyBones this is still python, right?
  12. Link Mauve But if you want to check against True or False, you have to do that cast.
  13. Link Mauve SaltyBones, sure.
  14. SaltyBones are there any programs where this was actually a performance issue?
  15. SaltyBones I always thought "is not None" was added to sort of make the type right
  16. lovetox so your saying it does not make sense with True and False
  17. lovetox SaltyBones, if not x:, would be valid if x is False and x is None
  18. lovetox but x beeing False could have other implications then None
  19. lovetox so you need "is None" if you want to test against None
  20. lovetox and not False
  21. Link Mauve SaltyBones, yes, I’ve been working on that kind of program.
  22. lovetox so Link Mauve if i do : if x is False
  23. lovetox is x cast to bool, even if it is bool?
  24. Link Mauve A RichCmp is very expensive in Python because it involves a call to bool(), which involves a potential call to the tp __bool__, in every single class of the inheritance tree.
  25. lovetox or to phrase it differently, is : if x is False, faster then, if not:
  26. lovetox or to phrase it differently, is : if x is False, faster then, if not x:
  27. Link Mauve lovetox, it doesn’t make sense to test for “is False” most of the time, because in this case you do want the check to cast into bool.
  28. lovetox so it would cast, even if it has that type already
  29. SaltyBones casting a bool to a bool cannot be slow though
  30. SaltyBones because that apparently requires gigantic inheritance trees :)
  31. bot Yann Leboulanger pushed 1 commit to branch _refs/heads/xep-0319_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *ae434700* <https://dev.gajim.org/gajim/gajim/commit/ae43470046e5efc300196d20a22796dcff7633d9> a presence that is the same as previously but with a different idle time is not the same as previously
  32. bot Yann Leboulanger pushed 2 commits to branch _refs/heads/xep-0319_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *dded06c5* <https://dev.gajim.org/gajim/gajim/commit/dded06c592e8dc21a4df91a7239aa036892e949f> a presence that is the same as previously but with a different idle time is not the same as previously *8a6f7997* <https://dev.gajim.org/gajim/gajim/commit/8a6f7997a64b566eb8c21832d98bf3a17c73faf4> Merge branch 'xep-0319' of dev.gajim.org:gajim/gajim into xep-0319
  33. bot Yann Leboulanger pushed 2 commits to branch _refs/heads/xep-0319_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *67ed9bd4* <https://dev.gajim.org/gajim/gajim/commit/67ed9bd427b642d15d95333b0ffad81b64d30d99> Merge branch 'xep-0319' of dev.gajim.org:gajim/gajim into xep-0319 *6c14a74c* <https://dev.gajim.org/gajim/gajim/commit/6c14a74ccdddfa567c284235128f90dc5c63978b> Merge branch 'xep-0319' of dev.gajim.org:gajim/gajim into xep-0319
  34. SaltyBones where did the "edit bookmarks" entry in the group chats menu go in the current git version?
  35. lovetox application menu -> bookmarks?
  36. lovetox do you mean that
  37. bot Yann Leboulanger pushed 1 commit to branch _refs/heads/xep-0319_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *873c0b51* <https://dev.gajim.org/gajim/gajim/commit/873c0b51489c9e6afc40ee5960b292c3f57fa2c7> Do not use XEP-0012 anymore to know idle time. Use XEP-0319 Fix tooltip alignment send idle info even when we manually set a non-online presence. use autoaway config option instead of send_idle_time to attache idle element to presence correctly get autoaway config value send XEP-0319 idle tag to groupchat presences fix coming back from autoaway improve idle time formatting in tooltip fix parsing since attribute fix missing return Revert "fix missing return" This reverts commit 10a50064cdae247f65fe7779b9d85522640e0e48. Revert "fix parsing since attribute" This reverts commit ff8c17c38473b7369c6872673a8539164d395b55. show idle time in local time a presence that is the same as previously but with a different idle time is not the same as previously a presence that is the same as previously but with a different idle time is not the same as previously
  38. bot Yann Leboulanger pushed 1 commit to branch _refs/heads/xep-0319_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *28917aaf* <https://dev.gajim.org/gajim/gajim/commit/28917aaf5647b6cc0c8e8d62d5dfe19fba48ef4b> Do not use XEP-0012 anymore to know idle time. Use XEP-0319
  39. bot Yann Leboulanger pushed 2 commits to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *28917aaf* <https://dev.gajim.org/gajim/gajim/commit/28917aaf5647b6cc0c8e8d62d5dfe19fba48ef4b> Do not use XEP-0012 anymore to know idle time. Use XEP-0319 *6a95fe79* <https://dev.gajim.org/gajim/gajim/commit/6a95fe79ae4345cc26e4aa0aadd6795408eeb012> Merge branch 'xep-0319' into 'master' Xep 0319 See merge request !110
  40. bot Yann Leboulanger pushed 0 commits to branch _refs/heads/xep-0319_ of _gajim_ <https://dev.gajim.org/gajim/gajim>:
  41. Link Mauve Asterix, Traceback (most recent call last): File "gajim.py", line 241, in do_activate from gui_interface import Interface File "/usr/lib/python3.6/site-packages/gajim/gui_interface.py", line 66, in <module> from groupchat_control import GroupchatControl File "/usr/lib/python3.6/site-packages/gajim/groupchat_control.py", line 43, in <module> import config File "/usr/lib/python3.6/site-packages/gajim/config.py", line 61, in <module> from common import connection File "/usr/lib/python3.6/site-packages/gajim/common/connection.py", line 63, in <module> from common.connection_handlers import * File "/usr/lib/python3.6/site-packages/gajim/common/connection_handlers.py", line 969 obj.contact.idle_time = obj.idle_time: # no change ^ SyntaxError: invalid syntax
  42. lovetox fixed
  43. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *e4936060* <https://dev.gajim.org/gajim/gajim/commit/e493606070b63bb077d9c51b24eb7ea4b971fca9> Fix typo
  44. Asterix I don't understand, I already fixed that ...
  45. Asterix lost in merge
  46. Asterix ha maybe that's the merge I was in the middle of
  47. lovetox ^^
  48. Asterix so what's new nice and usefull in 9.4?
  49. lovetox for example on a merge request, when you discuss issues, you can create a issue out of this discussion
  50. lovetox so you dont forget
  51. lovetox now people can create tags on issues, even if they are not Master
  52. lovetox if we wish so
  53. lovetox lots of stuff i dont understand was added and we do not use :D
  54. lovetox but i guess we will find out
  55. lovetox you can resolve merge conflicts inside the merge request on the website
  56. lovetox you can see this in the "make gajim a python package" merge request
  57. Asterix ok cool
  58. Martin Note to Debian users: unstable/testing (10 or Buster) has 0.16.8-3, stable backports (9 or Stretch) has 0.16.8-3~bpo9+1 oldstable backports sloppy (8 or Jessie) has 0.16.8-3~bpo8+1. So everything is up to date. Have fun!
  59. lovetox Thanks Martin, for your work !