Gajim - 2017-04-29


  1. bot Philipp Hörist pushed 12 commits to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *1a3d60c6* <https://dev.gajim.org/gajim/gajim/commit/1a3d60c63791416afeb30bf739bb96ea17c7e4c3> check for errors when adding a transport contact. Fixes #8196 *3bc6173a* <https://dev.gajim.org/gajim/gajim/commit/3bc6173a1176081043f7b7f57331e6b87a04afd1> Close IBB stream with correct SID. See #8555 *fde2ac73* <https://dev.gajim.org/gajim/gajim/commit/fde2ac731bd5686429ef4d9b617aa1e563b508d6> Close IBB Stream correctly *21700051* <https://dev.gajim.org/gajim/gajim/commit/21700051f8aa1cb559ce1fa12aa376896b8f5cbf> Read/Write file in binary mode *8c51eb72* <https://dev.gajim.org/gajim/gajim/commit/8c51eb72b9b873633ed90f32c82f82176f9ba84d> finish jingle file transfer session for files without hash *2ede0224* <https://dev.gajim.org/gajim/gajim/commit/2ede0224228ed42dd77dcaa4ba7fb1d9627c2759> Dont hash file on filetransfer error *0d8c0087* <https://dev.gajim.org/gajim/gajim/commit/0d8c00876489a0726fa40cea1850c154c85f2811> Fix typo in event type *3e592c98* <https://dev.gajim.org/gajim/gajim/commit/3e592c980eaac66d8bf701a5a7de66e4434aa6dc> Only make pause button active on pause-able transfers *385d6c30* <https://dev.gajim.org/gajim/gajim/commit/385d6c3081730f486807dddb3cd41eca1b7d007a> On IBB cancel set correct 'to' attr *7cb7bcaa* <https://dev.gajim.org/gajim/gajim/commit/7cb7bcaae6a7b34a3806f3865f3178191cea9566> Refactor IBB Handlers - Move handling of Data IQs into IBBIqHandler - Call SendHandler with file_props - Save last sent id in file_props.syn_id - Remove some useless checks, now that we call SendHandler with file_props - Send item-not-found error on invalid session id *3fb12148* <https://dev.gajim.org/gajim/gajim/commit/3fb12148b99190780609b33c8ec924259adda41a> Remove not working proxys *b94c8274* <https://dev.gajim.org/gajim/gajim/commit/b94c8274004c952c4ad4bc9a627bc31c7b64cec4> Merge branch 'fixibb' into 'master' Fix IBB Closes #8196 See merge request !90
  2. lovetox Link Mauve
  3. lovetox i ported all the IBB related fixes to master
  4. lovetox your first commit in your MR is fixed because of this
  5. lovetox also what is missing is renaming the candidate tag
  6. lovetox actually there is quite a lot missing to update gajim, i will work on it :)
  7. Link Mauve lovetox, what is that candidate tag?
  8. lovetox remote-candidate
  9. lovetox for socks5 filetransfer
  10. lovetox the tag was renamed
  11. lovetox also gajim doesnt set the "senders" attribute in the content tag, but im looking into that right now
  12. lovetox and your MR works only for sending, because on receiving we still parse for "request" and "offer" tags
  13. Link Mauve Wut, why did you remove the namespace check in https://dev.gajim.org/gajim/gajim/commit/7cb7bcaae6a7b34a3806f3865f3178191cea9566 ?!
  14. Link Mauve I can send you <iq><open xmlns="evil"/></iq> and you’ll happily accept that!
  15. lovetox no
  16. lovetox you cant, because this handler is only called if the namespace is in the iq
  17. lovetox its was unneccesary
  18. lovetox con.RegisterHandler('iq', self.IBBIqHandler, ns=nbxmpp.NS_IBB)
  19. lovetox im interested if this works out of the box now with your client, and maybe solves some of the issues you opened
  20. Link Mauve I’ll try to update, thanks.
  21. Link Mauve Uh, it won’t, because you are still implementing an ancient JingleFT version.
  22. lovetox then adapt it for your tests
  23. lovetox its not a 5 minute work to upgrade from 3->5
  24. lovetox gajim code is very modular for jingle
  25. lovetox or abstract
  26. lovetox it has to work with XSLT, audio/video, etc
  27. lovetox i need time to read into it
  28. Link Mauve XSLT?
  29. lovetox XTLS
  30. Link Mauve Ah.
  31. Link Mauve I don’t implement that yet.
  32. Link Mauve I was thinking about skipping it altogether and only implementing datachannels instead.
  33. lovetox if one class inherits from another
  34. lovetox can i just overwrite the methods when i have a method of the same name ?
  35. lovetox or does this not work in python
  36. Link Mauve Yes.
  37. Link Mauve You may want to call the super() one, but if you don’t want that behaviour at all you can skip it.
  38. lovetox ah damn this method is private
  39. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *b6db6026* <https://dev.gajim.org/gajim/gajim/commit/b6db6026be43c15a1184478e8ef504f90eeed19b> Fix typo
  40. lovetox such a little error
  41. Link Mauve lovetox, is it expected to have an underscore in “_Open Containing Folder”?
  42. lovetox nope
  43. lovetox yeah i fix that one moment
  44. lovetox i hate that word: mnemonic
  45. lovetox how is this even pronounced
  46. Link Mauve lovetox, https://en.wiktionary.org/wiki/mnemonic#Pronunciation
  47. lovetox impossible :D
  48. Link Mauve lovetox, there, updated the MR to make it work with my client.
  49. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *6a4cbf06* <https://dev.gajim.org/gajim/gajim/commit/6a4cbf06ec1be16a8ac8173b6db704035c756eb1> Fix Button labels
  50. lovetox please check if that fix works :)
  51. Link Mauve Yup, it does.
  52. Link Mauve But err, both Open Containing Folder and OK have the same mnemonic. ^^'
  53. Link Mauve You should never have that in an UI.
  54. lovetox interesting now what it does then when you use it
  55. Link Mauve It will just ask me for the correct one, waiting for me to press enter.
  56. lovetox what do you suggest we should take instead?
  57. lovetox C?
  58. Link Mauve Sounds sensible.
  59. Link Mauve Oh btw, when I hover a file transfer, I get “Type: ?Noun:Upload”, I’m pretty sure that’s not what you want.
  60. lovetox am no but this is translation stuff
  61. lovetox i have to look into it what it should actually do
  62. lovetox and why its not working
  63. bot Philipp Hörist pushed 1 commit to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *d0357eaa* <https://dev.gajim.org/gajim/gajim/commit/d0357eaa2944ddfd2e4532a958a613c81df14c1b> Use different mnemonic O is already used for the OK button
  64. Link Mauve Ok, the last three bugs I can still reproduce on master + my branches.
  65. Link Mauve I guess the next step for me is to implement proxy65.
  66. Link Mauve Because ibb is actually quite slow. ^^
  67. Link Mauve lovetox, what was that other thing you wanted me to fix?
  68. lovetox its ok, i fill in the missing stuff
  69. lovetox also the thing i want to test is socks5
  70. lovetox but daniel implements 5 now
  71. lovetox then we can test with conversations
  72. Link Mauve That’s what I meant with proxy65, yeah. :)
  73. Link Mauve Ok, I’ll continue in my Rust implementation then.
  74. bot Philipp Hörist pushed 3 commits to branch _refs/heads/master_ of _gajim_ <https://dev.gajim.org/gajim/gajim>: *fe3a5a4a* <https://dev.gajim.org/gajim/gajim/commit/fe3a5a4aeeb6d327c582b4cb673667386c69f85f> Make some methods public *1840ff23* <https://dev.gajim.org/gajim/gajim/commit/1840ff235e67146c4083643d8ba093352572d1be> Port Network Watcher to Gio API *89f1e982* <https://dev.gajim.org/gajim/gajim/commit/89f1e9820d744f84bf5d7b3a1bb20313934cf0db> Merge branch 'dbus' into 'master' Port Network Watcher to Gio API See merge request !88