Gajim - 2015-12-16


  1. tmolitor kalkin, if your plugin is ready, ask asterix for upload permissions to the plugin repo...this way every user can simply use the plugin manager to install your plugin from the official repo :)
  2. kalkin tmolitor: it is not ready its early alpha 😊
  3. tmolitor kalkin, yeah, but when it is ready, you should do that ;)
  4. tmolitor by the way, is there a emoji plugin for gajim? right now it is not very intuitive if you want to send emojis...
  5. tmolitor and emojis currently don't get replaced by their colorfull pictures, too...
  6. Link Mauve tmolitor, there is a Twemoji deck in the plugin manager, which I added not long ago.
  7. tmolitor Link Mauve, wow, sounds nice...I'll give it a try :)
  8. Link Mauve But I like my ttf-symbola font. :)
  9. tmolitor I like colored emojis more ;)
  10. tmolitor Link Mauve how does this work exactly?
  11. Link Mauve You enable the smiley set plugin, then select the one you want.
  12. Link Mauve I find that terribly unintuitive, but I don’t have the time to write anything better.
  13. tmolitor okay...that's ok...and then all utf-8 emojis are replaced by the icons defined in the plugin?
  14. Link Mauve Yes.
  15. tmolitor seems like nothing is happening...
  16. Link Mauve Really? ☺
  17. Link Mauve You can’t select the ones you want to use from the smiley icon?
  18. tmolitor no, the plugin isn't even showing up in the "installed" tab of the plugin manager...
  19. tmolitor okay...when I restart gajim, the plugin appears as installed...just tested it with my test profile...
  20. tmolitor then I select your icon pack in the emoticons tab of the plugin manager and klick install...
  21. tmolitor Link Mauve: but "☺" is still is the old one in black and white and not one of your nice icons :(
  22. Link Mauve Oh?
  23. Link Mauve Do you have SVG support elsewhere in Gajim?
  24. Link Mauve For example, do you see my avatar?
  25. tmolitor Link Mauve: yes...your avatar is visible...
  26. tmolitor something with a flame...
  27. tmolitor
  28. tmolitor hmmm...nothing happened...(the plugin is now available in my main profile without restart, too)...
  29. Link Mauve And can you see them in the smiley list?
  30. tmolitor yes, all of them...and it's a long list ;)
  31. Link Mauve And when you click on one, then press enter, you don’t see it in the chat?
  32. tmolitor where should I click one?
  33. tmolitor use the smilies button in the chat window?
  34. Link Mauve Yes.
  35. tmolitor this button does not contain your smilies...only those: :-D 8-) :-| and so on...
  36. Link Mauve So you haven’t selected it.
  37. Link Mauve It’s in the preferences, IIRC.
  38. tmolitor okay...
  39. tmolitor Link Mauve, that's it!!
  40. Link Mauve :)
  41. tmolitor
  42. tmolitor 😄
  43. tmolitor well...no...I selected it there, but now I don't see them in the chat window...only in the smilies button...
  44. tmolitor but one step further :)
  45. tmolitor well...okay...I have to restart gajim...
  46. tmolitor is it possible to ajust the size of the emojis? in my chat window they are very big...
  47. tmolitor https://xmpp-upload.datenknoten.me/-br3Vey7Wu4NBfiBX37qzQ3WxpA/liBfZbSmHlsTZ/emojis.png
  48. tmolitor Link Mauve: see the screenshot in my last message...
  49. Link Mauve Hmm, should be dependent on the size at which they get rasterized.
  50. Link Mauve Gajim can probably influence that.
  51. Link Mauve The width/height attributes on the document root are only a hint.
  52. tmolitor would be good if they were as big as the text surrounding them...
  53. Link Mauve IIRC Gajim knows that height, so it can adjust this size.
  54. Link Mauve My guess is that it never did because resizing raster images look bad.
  55. tmolitor yes...maybe...
  56. tmolitor do you know the position in the code where to change that?
  57. tmolitor maybe distinguish between svg and raster images there and do the resizing only for the svg images...
  58. Link Mauve No sorry.
  59. Link Mauve It’d be in the smiley to image regex code, I guess.
  60. tmolitor okay...yes...I came across this part in the code a few month ago...lets see if I can find it again...
  61. tmolitor Link Mauve, it would be nice if the "normal" smilies were grouped in the smilies menu....
  62. Link Mauve Normal?
  63. tmolitor the ones containing "faces" as opposed to the ones containing arbitrary images like rainbows or hammers...
  64. Link Mauve Ah, I remember I couldn’t figure out what kind of sort Gajim was using.
  65. Link Mauve Just left it like that.
  66. tmolitor Link Mauve, ah...that explains this chaos...
  67. Link Mauve In my metadata file it’s sorted by codepoint, codepoints that should be grouped in the exact same way they are in Unicode… I don’t know why Gajim unsorts them.
  68. tmolitor well...maybe I'll look after that, too....but for now I'll try to resize the svgs to a reasonable size first...
  69. Link Mauve It isn’t a resize operation btw, or shouldn’t be.
  70. Link Mauve What you want is to tell rsvg the size at which it should rasterize it.
  71. tmolitor where can I do that?
  72. Link Mauve Probably in the GTK+ view.
  73. Link Mauve But I don’t know.
  74. tmolitor Link Mauve, where are the svgs rasterized? just before they are displayed?
  75. tmolitor img = TextViewImage(anchor, gobject.markup_escape_text(special_text)) animations = gajim.interface.emoticons_animations if not emot_ascii in animations: animations[emot_ascii] = gtk.gdk.PixbufAnimation( gajim.interface.emoticons[emot_ascii]) img.set_from_animation(animations[emot_ascii]) gajim.log.debug("img pixbuf is: %s" % str(img.Pixbuf)) img.show() self.images.append(img) # add with possible animation self.tv.add_child_at_anchor(img, anchor)
  76. tmolitor that is the code to display the emoticons in the textview...
  77. tmolitor minus my debug output ;)
  78. Link Mauve I don’t know GTK+ enough to answer you. :/
  79. tmolitor hmmm...okay...then I'll have to search further...
  80. tmolitor Link Mauve, thanks for your help anyways...
  81. Link Mauve I think the smiley theme thingy could be improved a lot, good luck. :)
  82. tmolitor Link Mauve, thanks :)
  83. bot RSS: Feeds for Gajim • Ticket #8201 (traceback on launch) created won't start. tb: term@fort ~/soft/gajim $ ./launch.sh /home/users/staff/terminator/.local/share/gajim/plugins/gotr/ui.py:40: GtkWarning: Unknown property: GtkMenu.ubuntu-local self.B.add_from_file(self.GTK_BUILDER_FILE_PATH) Traceback (most recent call last): File "gajim.py", line 533, in <module> interface.run() File "/home/users/staff/terminator/soft/gajim/src/gui_interface.py", line 2722, in run gajim.plugin[…] https://trac.gajim.or[…]
  84. caps Hi guys, Do you have a clue why python-farstream is not availble in Debian/sid?
  85. daniel Can somebody either tell me or point me to an example on how a plugin can add a menu item to the account context menu? The one that shows if I right click on the account and that has status, personal events, add Contact and so on in it?
  86. arune <Link Mauve> tmolitor, there is a Twemoji deck in the plugin manager, which I added not long ago.
  87. arune I cannot find twemoji plugin??
  88. Link Mauve arune, it’s with the other smiley set plugin.
  89. Link Mauve (I know, that’s terrible.)
  90. arune emoticon pack plugin?
  91. arune Link Mauve, thanks, got it, yes that was not very intuitive
  92. arune even with the log from tonight
  93. arune Link Mauve, tmolitor: can you confirm that twemoji doesn't work on windows? lack of SVG-support?
  94. Link Mauve I don’t have any Windows machine, sorry.
  95. arune Link Mauve, your avatar is not displayed in gajim on windows at least
  96. Link Mauve That’s an issue.
  97. Link Mauve likes how he is a testcase for SVG. :D
  98. arune you should change your nick to "If you don't see my avatar then your system cannot display SVG"
  99. tmolitor asterix, arune: gajim has a race condition in the smacks extension...
  100. tmolitor when smacks is activated after the connect plugins (at least via the 'chat_control_base_update_toolbar' gui extension point) and other code can already send stanzas while smacks hasn't replayed the stanzas still in the out queue...
  101. tmolitor the result is a wrong stanza count (server has a higher count than gajim)...
  102. tmolitor in combination with another bug this ensures that the outgoing stanza queue is NEVER cleared...now, when the client reconnects after a network failure *ALL* stanzas queued in this outgoing stanza queue (read: all stanzas you ever send since your *first* smacks enabled reconnect) get resent....
  103. tmolitor but even then the outgoing stanzas queue isn't cleared, so those messages get resent over and over again on every smacks enabled reconnect...and the queue further accumulates all outgoing stanzas...
  104. tmolitor even without the race condition that leads to the initial stanza count mismatch, this behaviour on a stanza count mismatch, where the server counts more message than gajim, is really dangerous...smacks should be disabled in such a case and/or the stanza count queue should be cleared completely...
  105. tmolitor at least this is what prosody does when the remote stanz count is greater than his own...it leaves smacks enabled, but clears the complete outgoing queue...
  106. arune tmolitor, patch on the way? ;)
  107. tmolitor arune: half of it ;) I patched it for my local version because it was kind of annoying ;)
  108. tmolitor the httpupload plugin triggers the initial race condition...
  109. tmolitor but I only fixed the accumulation of stanzas in the outgoing queue for now...
  110. tmolitor arune, asterix: another problem I encountered on the way: gajim uses a simple counter for its stanza ids...and this counter somehow gets reset on reconnect leading to duplicate ids in one session....a fix would be to just use randomly generated uuids as conversations does...
  111. arune it's great that you dare to look so deep into the code :)
  112. tmolitor well....it was *really* anoying :D
  113. kalkin Thanks god I'm not the only one how thinks its partly terrible
  114. tmolitor kalkin, no, the ode is ok (some more comments would be nice, but apart from that its quite readable)...but this bug was really anoying ;)
  115. tmolitor Link Mauve, after digging deeper into the smilies code I think the best fix for the problem would be to resize your svg images to the same size all other smilies have...so the size would be consistent across different icon sets at least...
  116. tmolitor Link Mauve, your icons have a default size of 47,5 px while all other icons have a size of 24 to 32 px...I think 32 px should be enough...
  117. tmolitor well ok...some of them are even smaller (16px)...
  118. tmolitor or maybe even 24 px would be better...
  119. tmolitor Link Mauve, I just resized your icons to 24px...I'll send you the new zip file...could you update your icon slice with that (I would consider it very rude to do this myself as I'm not the author of this)...
  120. tmolitor https://xmpp-upload.datenknoten.me/-br3Vey7Wu4NBfiBX37qzQ3WxpA/72w49ymHXpjrx/emoticons_pack.zip
  121. tmolitor Link Mauve, this is the new zip with the changed icons of the Twemoji pack :)
  122. arune Good work, I'd appreciate better sized emojis ☺
  123. arune I'd also like them to work on windows though
  124. tmolitor arune, link mauve: well...that would imply, that the emojis either were saved as png files (I think link mauve wouldn't like that) or the svg support for windows would be repaired (that would be the option I'd go for)...
  125. arune Why should they be svg when they are not automatically resized? I thought that was the main pro for svg
  126. daniel To my knowledge gajim also doesn't verify the sender of the iq response. Combined with predictable stanza ids it's very very easy to do very nasty stuff
  127. tmolitor daniel: that could be possible, too...I think using uuids for stanza ids is just best practice...
  128. daniel tmolitor: doesn't have to be uuid. Just random ones are enough
  129. tmolitor asterix: I just created this bug: https://trac.gajim.org/ticket/8202
  130. tmolitor daniel, yes, but they should have enough entropy...1 bit random numbers wouldn't be enough ;) and uuids are very large (128 bit), so accidental collisions should be very *very* rare...
  131. daniel tmolitor: well they should be unpredictable. Uuid are very verbose. I use them for message stanzas. But anything else can just be an alphanumeric string. That probably saves you some bytes on the connection
  132. daniel There is no reason to limit yourself to the uuid convention
  133. bot RSS: Feeds for Gajim • Ticket #8202 (smacks resends *all* message since session startup on every reconnect) created Bug description gajim has a race condition in the smacks extension… when smacks is activated after the connect plugins (at least via the 'chat_control_base_update_toolbar' gui extension point) and other code can already send stanzas while smacks hasn't replayed the stanzas still in the out queue… the result is a wrong stan[…] https://trac.gajim.org/ticket/8202 • gajim_2_debug.log[] • xm[…]
  134. Asterix tmolitor: yes I saw. Thanks for the detailed report
  135. tmolitor asterix: some patches are following, too :)
  136. tmolitor I'm creating them just now :)
  137. Asterix ho excellent!
  138. tmolitor daniel, I was only talking about message stanzas and their ids...the id="xxx" property of every stanza to be concrete...
  139. tmolitor I'll create a patch to use uuids there...
  140. tmolitor asterix: where can I find the nbxmpp repo?
  141. Asterix https://hg.gajim.org/python-nbxmpp/
  142. tmolitor https://python-nbxmpp.gajim.org/ displays a lot of errors...
  143. Asterix ha indeed ...
  144. tmolitor and conference,gajim.org uses an expired certiicate and hsts --> can not be displayed in browsers like firefox or chrome...
  145. Asterix I'm creating certs on letsencrypt. I switch all my certs there when I have a few time
  146. tmolitor Asterix, ah okay, nice :)
  147. Johannes Asterix is there an overview of what the two branches in the main repo are supposed to contain?
  148. Johannes there's the default that yields a 0.16.x gajim and the gajim_0.16 branch
  149. Johannes both appear to be maintained
  150. Asterix default if for GTK3 / py3
  151. Asterix it's work in progress and will be the next major release
  152. Johannes I see. And the other one gtk2 and what currently is on release?
  153. Johannes Thus I can probably expect breakage on the default branch? Aside from a weird GTK crash I'm seeing this one seems to miss the plugin system...
  154. Johannes (On the Mac)
  155. Asterix python-nbxmpp is back
  156. Asterix Johannes: yes exactly. Not everything works correctly in default, but I try to fix things when I see bugs (I use the default branch)
  157. Asterix Johannes: plugin system is supposed to work, but we have to update the version to 0.16.9 so that it's recognized as GTK3 branch ...
  158. Link Mauve tmolitor, I explicitly didn’t want to modify the SVG files themselves to make the import from a new Twemoji revision easier.
  159. Link Mauve arune, I’d much prefer the smiley code to rasterize them at the right size.
  160. arune oh god, and fix the sorting in gajim :)
  161. Link Mauve I’d rather find a room before I get thrown out. ^^'
  162. tmolitor Link Mauve, it is very easy to convert the svgs...just use this short bash script in the folder containing the svgs: for file in *.svg; do rsvg-convert -a -w 24 -f svg $file -o out_$file; rm $file; mv out_$file $file; done
  163. Link Mauve tmolitor, ugh, and what about people using a higher DPI screen, for example?
  164. Link Mauve No really, vectorial images are fine, they should just be displayed at the wanted size.
  165. tmolitor Link Mauve, then either fix this resizing stuff or use the resized svgs as solution (at least as temorary solution till the proper resizing is implemented)...
  166. Link Mauve Yeah, but I don’t really have the time currently.
  167. tmolitor Link Mauve, then resize the images till you have enough time or another person fixes this...
  168. Link Mauve But that’s a really bad solution. :/
  169. tmolitor Link Mauve, but at least it *is* a solution....
  170. Link Mauve I quite disagree, it fixes it for half of the users, while making it worse (way too small smileys) for the other half.
  171. Link Mauve You could say those ones are used to most software rendering badly on Linux, but still.
  172. tmolitor Link Mauve, well...24px is still quite large...almost double of the normal line height (at font size 12)...and i doubt some user is using a font size bigger than 24...
  173. Link Mauve tmolitor, what was the issue that made you unable to set the proper dimension of the smileys in the chat view, btw?
  174. tmolitor Link Mauve, I don't know how to do it...there is no size property in gtk image used and gajim uses some animation stuff (for gif emoticons) making things more complicated, too...
  175. Link Mauve Oh, we should make animated SVG smileys then!
  176. Link Mauve For science!
  177. Link Mauve Although, I’m pretty sure librsvg doesn’t support that.
  178. tmolitor Link Mauve, would surely look great ;) but back to topic...if you still refuse to resize the emoticons so that they are useful, I'll fork your icon set and create m own one with exactly the same images just smaller...
  179. Link Mauve Sure, you can do that.
  180. Link Mauve But I still think the issue should be fixed instead of having that terribly ugly workaround.
  181. Link Mauve Using raster images in this era for vector data is a total non-sense.
  182. tmolitor well, you're right....but neither me nor you have enough time to fix it "the right way" ant untill there is a good solution I prefer the resized images over no solution (no solution would be a *very bad* solution)
  183. tmolitor *and not ant
  184. Link Mauve I’m pretty sure you are the only person on Earth with arune who have enabled this smiley set, btw, given how unintuitive it is. :p
  185. tmolitor Link Mauve, that is a very bad argument to not fix this problem at all ;)
  186. Link Mauve That’s a good argument to not fix it the bad way in a hurry.
  187. tmolitor Link Mauve, NO, if you think so almost half of computer stuff would not be here in this world...most times there is no "academic perfect solution" possible...and to rather go with no solution than with an maybe imperfect (in rare circumstances) solution would have us being still at stone age...and I'm pretty sure most people would agree with me on this...
  188. tmolitor Link Mauve, but it's ok...keep your (in my eyes stupid "I don't want to fix things, even if it improves a little bit, because I want to make everything perfectly right) opinion...I will just fork your icon set and that's it...
  189. tmolitor the whole gajim is not perfect in any way...and if asterix would think like you...there would be no gajim at all...
  190. Link Mauve tmolitor, there is a difference between not improving things, and focusing on a tiny issue that touches approximately nobody when it’s a matter of days until somebody has the time to look at fixing it properly.
  191. tmolitor Link Mauve, well...I don't think it's a matter of time...but let time prove it...if it isn't solved in 3 month I would guess I was right ;)
  192. tmolitor besides this...tiny issues accumulate, too ;)
  193. arune tmolitor: could you convert them to pngs in your fork? Then I'd roll it out to our users and that will increase the usage with about 2500%! ☺
  194. arune Doing a workaround also makes the emoji set usable until there's a new release of gajim (even if there were proper patches today that does not mean it's usable until there's a new release)
  195. tmolitor arune: yes, pngs are possible, too (the same command I posted earlier....I guess it doesn't matter at all if you have fixed size svgs or fixed size pngs...
  196. tmolitor arune: could you figure out how to add the new icon set to the emoticons plugin, too?
  197. tmolitor I'll upload it then...
  198. arune tmolitor: I guess I could, when I get to a computer I'll have a look, thanks