Gajim - 2015-10-28


  1. tmolitor asterix: mod smacks is going crazy after a stanza count mismatch and sends *many* old messages again...not sure why the message count is wrong, but I think gajim should do a clean reconnect in this cases rather than operating on false values and doing things you don't expect (such as spamming other users with already sent messages)...
  2. tmolitor instead of logging only this entry: 27.10.2015 21:11:51 (E) nbxmpp.smacks Server and client number of stanzas handled mismatch
  3. tmolitor asterix: the spamming started after a reconnect and thus replaying the messages according to the (false!!) smacks ack status...
  4. arune tmolitor: which server? There were a few bugs and updates to prosody mod smacks if I remember correctly
  5. tmolitor asterix, arune:latest prosody 0.10 and mod_smacks (updated dayly)
  6. Link Mauve tmolitor, how can Gajim know if it’s a bug or if the server actually never got those messages?
  7. Link Mauve I’d say the main issue here is the server allowing it to resend messages it knows were already transmitted.
  8. tmolitor Link Mauve, as I said, gajim knows the smacks counters are wrong and it shouldn't work with this wrong values...period...
  9. Link Mauve Wrong as in its own count is lower than the server’s?
  10. tmolitor Link Mauve, maybe, I don't know...I only have the log message I cited...
  11. Link Mauve It would be useful to improve this message, to help people debug such issues.
  12. tmolitor asterix, arune:latest prosody 0.10 and mod_smacks (updated dayly)
  13. tmolitor Link Mauve, as I said, gajim knows the smacks counters are wrong and it shouldn't work with this wrong values...period...
  14. tmolitor Link Mauve, maybe, I don't know...I only have the log message I cited...
  15. Holger tmolitor: What should Gajim do in that case?
  16. Holger tmolitor: Kill the connection? Never resend any message, because message loss is better than message duplication?
  17. Holger Hrm if the problem is that the server acknowledged more stanzas than the client sent, then yes it should most probably not resend any.
  18. tmolitor holger: no, kill the connection and reconnect without resuming the old smacks session...
  19. tmolitor this way no messages are lost, but duplicated messages are prevented because subsequent messages will be send over the new (clean) connection
  20. Holger If the old one was not "clean", chances are the new one won't be, either. And you will often have no chance to detect that.
  21. tmolitor holger: maybe wait for an xmpp ping to succeed before killing the connection (making sure all messages up to the ping have been correctly delivered)...
  22. Holger always thought this stanza counting is a bad idea :-/
  23. tmolitor well...that depends on the root cause for the wrong message count...in my case it was usage of the xml console to send a message manually....
  24. Holger And that's not counted by Gajim?
  25. tmolitor seems so...
  26. Holger That would be an easily reproducible bug then.
  27. tmolitor I didn't recognize it till the next reconnect (a couple of hours later) and then all messages since my manual message got resent....and the next reconnect resent all messages again (it happened like 3 times :/ )
  28. tmolitor holger, asterix: yes, it is reproducible, I just tested it :)
  29. Holger Indeed, that behavior doesn't make sense. Maybe there's an additional bug that lets Gajim resend all messages if it thinks the server's count is too large?
  30. Holger I.e. (1) XML console input is ignored, (2) apparently-too-large server counts aren't handled in a sane way.
  31. tmolitor I don't know...but I think these two bugs should be fixed (count messages even when the xml console is used AND better handling of counting errors in case something still goes wrong)...
  32. tmolitor my counts are not very large...
  33. tmolitor 545 and 819 stanzas (both directions)
  34. Holger Yes, what you said sounds like Prosody says "I received 545 stanzas" and Gajim thinks "WTF, I only sent 544" (because it didn't count the stanza you sent from the console).
  35. Holger So Gajim thinks the number 545 is too large. That's what I meant.
  36. tmolitor holger: yes, sounds logical
  37. bot RSS: Feeds for Gajim • Ticket #8169 ([patch] fix endless error messages loop) updated I tested with hg trunk first but still got the error. the message looks similar but i guess the code path was not covered by the previous patch. i got different errors, something like 'server not found' quite often. https://trac.gajim.org/ticket/8169#comment:4