tmolitorarune: I uploaded the new plugin version to our well known location...
tmolitorarune: please add builtins and __builtin__ into the ignore list and test it...
aruneWill do, sleep time now, good night
aruneNice work!
tmolitorarune: good night, sleep well :)
tmolitorthanks!
arunetmolitor, IT WORKS! great work, even conversations displays the image, I guess this is because the raw url is detected
arunebug when sending in a MUC:
Traceback (most recent call last):
File "/home/arune/.local/share/gajim/plugins/httpupload/httpupload.py", line 250, in upload_complete
if not self.chat_control.gpg_is_active and self.dialog_type == 'image' and is_image:
AttributeError: 'GroupchatControl' object has no attribute 'gpg_is_active'
aruneeven if I remove the check for gpg there is still something not working in a muc, seems like the picture is first displayed in gajim when I send the next message
arunetmolitor, maybe we could add a config dialog where you can set the thumbnail size, maybe allow upp to 300?
botRSS: Feeds for Gajim
• Ticket #8092 (Overrides ~/.config/gajim/config symlink) updated
You do know about lstat(2) and readlink(2), right?
https://trac.gajim.org/ticket/8092#comment:2
tmolitorArune: okay, a config Dialog would be nice, yoa ca add ohne if you want :)
tmolitorArune: i don't understand what you mean...what is happening in a muc?
arunetmolitor: I select share image, then chose file, klick send/whatever
aruneBut nothing is sent until I write a normal message and send that
aruneThen both the image and the message are sent
KeitaroIs there a way to force gajim to use a specific language ?
Link MauveKeitaro, export LANG=language_COUNTRY.UTF-8 in your environment before starting it.
Link MauveLike for exactly any other program.
Keitaroty for your answer, I'll do that to fix my issue :)
Keitaronow, about the "like for exactly any other program", that's not true.... every other program have listbox
Keitarogajim is really not user friendly :) no offense, just expressing my point of view and I respect all the work done on it, it's a great client under the hood (the best imho)
Keitarohaving to set local var is something very few users can do....
Link MauveUsually their desktop environment does it for them.
Keitarothat's true
ZashWith a select box
Link MauveAlso, users usually don’t want to set the language for a single program, and instead set it for their entire computer.
Zashso every single application don't have to
Link MauveOr at least, session.
Keitarobut is in my case, under ubuntu 14.04, the whole system is in french, but gajim is in english...
KeitaroI saw this behavior on 2 different ubuntu computers
ZashSounds like you don't have frensh translations then
Link MauveHave you installed it correctly, from a package?
Link MauveOr are you running it from a clone, without having compiled the locales?
Keitaronot from a package (ubuntu PPA is wayyy outdated, like 2011) so I had to get the source and compile it yeah
Link MauveAnd now you are talking about user-friendliness? :p
Link MauveBut there is a Debian repository you can use.
Link MauveAFAIK it works on Ubuntu as well.
Link MauveYou likely forgot to install the compiled locales where Gajim would find them, btw.
Link MauveA make install would fix that, probably.
KeitaroI did a make install of course
Keitarolet me check the INSTALL or README to see what they say about compiling language files...
Keitaro
tar jxvf gajim-version.tar.bz2
cd gajim
./configure
make (builds translations)
su -c make install
Keitaroso that's what I did :/
tmolitorarune: that's strange, I'll look into it...
tmolitorarune: did you get the muc log of the conversations chatroom?
tmolitorarune: I can reproduce your muc problem...strange thing...
tmolitorarune: if I don't send the xhtml (only the normal text), the message is sent immediately...
tmolitorarune, asterix: I think I know what is the problem here: messages sent via chat_control.send_message() can only be ~16384 bytes in size, if they are bigger, the second portion of the data is sent, wenn the next message to the server is sent (can be a whitespace keepalive or a xmpp ping)...
tmolitorarune, asterix: I think this is a bug in gajim or even in nbxmpp...
tmolitorarune: if you wait some time, your image is sent, even if you don't send another message...
arunetmolitor: the src should be a bob according http://xmpp.org/extensions/xep-0231.html
aruneAlso see http://www.xmpp.org/extensions/xep-0071.html#profile-image
aruneThe XHTML specification allows a "data:" URL RFC 2397 [22] as the value of the 'src' attribute. This is NOT RECOMMENDED for use in XHTML-IM, because it can significantly increase the size of the message stanza and XMPP is not optimized for large stanzas. If the image data is small (less than 8 kilobytes), clients MAY use Bits of Binary (XEP-0231) [23] in coordination with XHTML-IM; if the image data is large, the value of the 'src' SHOULD be a pointer to an externally available file for the image (or the sender SHOULD use a dedicated file transfer method such as In-Band Bytestreams (XEP-0047) [24] or SOCKS5 Bytestreams (XEP-0065) [25]).
arunebut sending from gajim TO conversations still works okay
botRSS: Feeds for Gajim
• Ticket #8137 (demandimport ignore for using PIL/Pillow [PATCH attached]) created
problem
Unable to use PIL/Pillow in a Gajim plugin. A traceback is displayed. analysis
Gajim demandimport fails for some imports in PIL/Pillow.
enhancement recommendation
Add the imprts to the demandimport ignore list.
https://trac.gajim.org/ticket/8137
aruneasterix, are more changes needed to being able to use PIL/Pillow in a plugin?
arunelike some dependency list or something
tmolitorarune: when asterix comes online again, I'll get commit access to the repo, I guess...so I'll upload the httpupload plugin then :)
arunegreat
arunebut did you see what I wrote about sending the image src-data?
tmolitoryes, I saw it...but I think bob support is just too complicated...
tmolitoror does gajim have bob support already?
Link MauveIt does.
Link MauveOnly wired for CAPTCHA for now, AFAIK.
tmolitorarune: okay...then: how can I use it?
aruneisn't it used by some other send-image also?
ZashIsn't BOB the most trivial of file transfer schemes?
tmolitorno, the image plugin uses data: urls to send images....
tmolitorzash: maybe, but my time is limited :/
arunetmolitor, which image plugin do you mean?
aruneaha, that one
arunehaha, we could always check the file size of the thumb and make it smaller in decrements until it fits :)
arunetmolitor, and change to jpg?
tmolitorarune: that's exactly what I'm doing now :D
tmolitorarune: I just changed to JPEG and wrote some loop to adjust the quality...
arunehaha
arunethere's some code about bob in src/common/connection_handlers.py
botRSS: Feeds for Gajim
• gajim.py.diff attached to Ticket #8137
PATCH
https://trac.gajim.org/attachment/ticket/8137/gajim.py.diff
aruneget_bob_data but I guess that is for downloading the bob
tmolitorI need something to publish bob data, not download it...
Zashbob has the benefit / complexity of being optional to download
tmolitorzash: embedding a small enough picture in xhtml-im doesn't even need any download...
Zashtmolitor: But then you can't not download it
ZashA mobile client can't delay fetching it until the user actually picks their phone out of their pocket
tmolitorzash: that's right...but it is only a thumbnail smaller than 8kb...
Link MauveA console client will still receive the data, even though it’s very unlikely they will do anything with it.
Link Mauvetmolitor, 8kb is a lot already.
tmolitorLink Mauve, that's right, but anybody can send you large stanzas that your console client doesn't use...that's a problem of your client...there are a lot more stanzas your client will probably ignore...
Zash8KiB base64 encoded is ~10kb
Link Mauvetmolitor, well, this isn’t a reason to force it on everyone.
Link MauveI file bug reports to clients that don’t play nice.
Link MauveAnd sending big images to client that have not asked for it is a very bad practice.
ZashAnd it's not much in the spirit of XMPP to blindly send large blobs of data without at least advertising support for receiving it
tmolitorzash: no, I measure the size after base64 encoding...
tmolitorbut maybe 1kb of data is enough for a small thumbnail...
tmolitorI'll test it...
ZashAlso, servers may have stanza size limits.
Link Mauvetmolitor, this isn’t a good way, period.
Link MauveBoB is one, proper file transfer as well.
ZashTho a proper file transfer for a thumbnail might be overkill
Link MauveOf course.
arunetmolitor: small thums are rather useless
ZashWouldn't big thumbnails be an oxymoron
tmolitorarune: and big ones can't be transferred properly :/
aruneI'm not at the computer more tonight but I can investigate more the bob support
tmolitorif using bob is more than trivial I don't have the time to do this (at least for the next couple of weeks)...
tmolitorarune: that would be very kind of you :)
aruneWe might be able to fix that later
tmolitoryeah...
arunetmolitor: the image plugin uses src-data and send images below 40k(?)
tmolitorarune: yes...
ZashSurely you can get acceptable thumbnails in 1Kib or less
botRSS: Feeds for Gajim
• Ticket #8123 (GnuPG-encrypted messages doesnt saved on server correctly) updated
since 0.16.2, Gajim don't ask to server to not store GPG encrypted messages. See #7616
https://trac.gajim.org/ticket/8123#comment:5
Asterixtmolitor: ping?
botRSS: Feeds for Gajim
• []
• Ticket #7295 (Metacontact don't work in GTK3 branch) updated
If I knew it, I'd fix it. But enabl[…]
https://trac.gajim.org/ticket/7295#comment:12
• Ticket #8135 ([RFE] Show fi[…]
https://trac.gajim.org/ticket/8135#comment:1
• Ticket #8136 (Directory pat[…]
https://trac.gajim.org/ticket/8136#comment:1
Asterixis it me or is this guy not very pleasant?:
https://trac.gajim.org/ticket/8092#comment:2
aruneAsterix: to early to tell
aruneNeed more data
aruneIt's closed so let it go
aruneAsterix: I'll test the ignore-thing in the plugin, thanks!
botRSS: Feeds for Gajim
• Ticket #8137 (demandimport ignore for using PIL/Pillow [PATCH attached]) updated
Status changed
Could you append those modules to demandimport.ignore in the plugin itself before importing PIL? Gajim itself don't use PIL. Hard to guess all modules that will be used by plugins …
from common import demandimport
demandimport.enable()
demandimport.ignore += ['builtins', '__builtin__']
https://trac.gajim.org/ticket/8137#comment:1
Asterixarune: nice, tell me if that works
aruneAsterix, on windows, will PIL be available for the plugin?
Asterixonly if I package it. I already package goocanvas for the whiteboard plugin for ex, so why not PIL
botRSS: Feeds for Gajim
• gajim.manpage.tar.xz attached to Ticket #8[]
• Changeset [[…]
https://trac.gajim.org/changeset/fccc624c66cbe094a4f4904c5926a12ab4322f4a
• T[…]
https://trac.gajim.org/query?id=7719,8136
• Ticket #8138 (Gajim asks for password for anonymous accounts) created
Bug description
Gajim asks for password for anonymous accounts when user cancels/rejects/skip GNOME keyrin[…]
https://trac.gajim.org/ticket/8138
Asterixarune: and the plugin can have a self.activatable variable that can be False if PIL is missing for example
aruneyes, or don't send the xhtml-im with the thumbnail
Asterixyes right
arunebut I guess for windows it would be really nice to have it in gajim already
aruneAsterix, it worked adding to the ignore-list in the plugin, thanks, I will close the issue
aruneI cannot close maybe?
tmolitorasterix, arune: I did the self activatable stuff in the plugin already...if there is no pil sthe xhtml thumbnail would not be send...
Asterixarune: done
arunetmolitor, great!
aruneAsterix, should I open an issue about adding PIL to the windows package?
Asterixno, I'll try to think about it, and if I don't , the ticket won't help
Asterixbt I'm not sure to add it for 0.16 branch. Now I'm working on defalt GTK3 branch
Asterixwill try. Are you able to test a windows installer to see if my package work?
Link MauveImo it makes more sense to go forward to the 0.17 branch.
Asterix0.17 branch? what's that?
aruneAsterix, yes
Link MauveAsterix, I mean default.
arunetmolitor, did you fix the gpg-thing aswell?
Asterixarune: ok when I'll built it, I'll give you an installer to test then
aruneAsterix, great!
AsterixLink Mauve: yes but it's not for tomorow ...
botRSS: Feeds for Gajim
• Ticket #8133 (Gajim fails to start on fresh configuration) updated
I'd still like to fix the problem by also deleting the cache.db and create a new one(anyway the data in it can't be ok as they refer to the logs.db ids). But I cannot reproduce the bug, are you able to?
https://trac.gajim.org/ticket/8133#comment:3
• Ticket #8137 (demandimport ignore for using PIL/Pillow [PATCH attached]) closed
worksforme
https://trac.gajim.org/ticket/8137#comment:3
Link MauveSo you are going to make yet another major release with gtk2 and so on, before then?
Asterixno, 0.16.4, then I hope it'll be 1.0 (default)
Link MauveOk.
arunetmolitor, in upload_complete the variable mime_type is used, but it's not set in that function an is not global?
arunealso the uploader function uses it?
AsterixLink Mauve: do you know what's the current way to know if system is configured to use single click instead of double click?
Link MauveI have no idea.
Link MauveAFAIK this isn’t a system settings, but an application setting.
Link MauveOr maybe a DE one, at most.
Link MauveI could ask around at work tomorrow if you want.
Asterixwhy not
Link Mauve(GNOME devs.)
Asterixelse I'll just remove completly the feture
Asterixelse I'll just remove completly the feature
Link MauveI think it’s the best thing to do.
Asterixif it has been implemented it's because one day a user asks for it, so why not keep it ...
Link MauveWhich reminds me I still haven’t tested Gajim on GTK+ 3.18, where getting the screen physical size should actually work.
Asterixif there is a DE option for that
Link MauveWell, it will always be at most DE-specific.
Asterixbetter that nothing ...
Link MauveYou could keep the setting of the single/double click, but remove the desktop integration.
Link MauveFar, far away, in the ACE.
Asterix:)
Asterixyes ..
AsterixI'll think about it while sleeping. GN
Link Mauve\o_
botRSS: Feeds for Gajim
• Ticket #8123 (GnuPG-encrypted messages doesnt saved on server correctly) updated
You no longer set the tag, which means you now allow those messages to be carbon-copied. But you still set the hint, which tells the server not to store them.
https://trac.gajim.org/ticket/8123#comment:6