aruneok, making <a href="url"> <img src="url"> </a> did not work, loging an image worked but making it linkable by nesting it in an a-tag did not work
arunebut instead of printing the full url I currently do <a href="url">open</a>, next I'll test Asterix solution
arunealso, if the image could not be downloaded, the url is printet with the error message
botRSS: Feeds for Gajim
• Ticket #8116 (GNU GPL is not an EULA) created
phenomenon
Gajim installation wizard asks users to agree with the GNU GPL license, even though they do not have to in order to use Gajim.
background analysis
https://drj11.wordpress.com/2008/02/25/the-gnu-gpl-is-not-an-eula/
implementation recommendation
Put a title says GNU General Public Notice, and provide a hyperlink to the license, similarly to how some big business companies do.[…]
https://trac.gajim.org/ticket/8116
aruneAsterix, I tried your patch here https://paste.gajim.org/view/d515850c but nothing happens on button click
aruneI wonder if there is anything more I need to do after editing /usr/share/gajim/src/conversation_textview.py befor running /usr/bin/gajim
arunetheres no output in console output
aruneok, my changes is being used at least
arunebut I put a line in 'on_button_press_event' which should raise an error and that doesn't happen when I press a picture
aruneso it seems the signal is not received by gajim or not sent to gajim
Asterixtrying to debug ... but I'm not getting the image for the moment :/
arune:)
Asterixok an import gobject is missing in the plugin ...
Asterixnow I get the image, and it's partially clickable
arunehm, not clickable anywhere here, are you on gtk3?
Asterixno
Asterixand I don't know how to not print the URL given the way it's currently done ...
arunejust a self.textview.plugin_modified = True after gajim.thread_interface is called
arunebut then one needs to print the url if downloading the image failes, but that parts I got covered
Asterixhaha you know plugin system better that me :)
Asterixyep ok
aruneit's a lot of code and I have only looked at those particular parts, but yes, one lerns something in 5-10 hours looking at new code :)
Asterixnow image is no more clickable. I think it's because the clickable area of the url is larger that the text
aruneaha, yes, thats why I thought the image was clickable when I first started!
arunehalf of the image was clickable
Asterixok I know why button_press callback is not called ...
Asterixhmm no ...
Asterixnow I know:
gtk.Image is a "no window" widget (has no gtk.gdk.Window of its own), so by default does not receive events. If you want to receive events on the image, such as button clicks, place the image inside a gtk.EventBox, then connect to the event signals on the event box.
arunethanks
arunemaybe the same problem when trying to make the image clickable by using html as I tried yesterday
Asterixmaybe yes
AsterixI'm trying to add it to an eventbox ...
Asterixgot it!
aruneGreat
aruneWould have taken me weeks
Asterixhttps://paste.gajim.org/view/9e0fa27a
Asterixbut there is still a modification to do in Gajim itself so it can handle the case where the image is in an EB
Asterixarune: version with printing URL when image loading fails:
https://paste.gajim.org/view/0a96b8f9